From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA41C4338F for ; Thu, 12 Aug 2021 02:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87E6D60E09 for ; Thu, 12 Aug 2021 02:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbhHLCIS (ORCPT ); Wed, 11 Aug 2021 22:08:18 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:8400 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbhHLCIR (ORCPT ); Wed, 11 Aug 2021 22:08:17 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GlVNS1Kwvz86Nx; Thu, 12 Aug 2021 10:03:52 +0800 (CST) Received: from dggpeml500006.china.huawei.com (7.185.36.76) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 12 Aug 2021 10:07:48 +0800 Received: from [10.174.176.127] (10.174.176.127) by dggpeml500006.china.huawei.com (7.185.36.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 12 Aug 2021 10:07:47 +0800 Subject: Re: [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP To: Christoph Hellwig CC: Luis Chamberlain , , , , , , , , References: <20210720182048.1906526-1-mcgrof@kernel.org> <051ab019-5163-e691-43ed-052401b6b95a@huawei.com> From: luomeng Message-ID: <200816d2-4cfe-a26d-88c8-a0cde0b8614b@huawei.com> Date: Thu, 12 Aug 2021 10:07:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.127] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500006.china.huawei.com (7.185.36.76) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org ÔÚ 2021/8/11 13:19, Christoph Hellwig дµÀ: > On Wed, Aug 11, 2021 at 10:42:20AM +0800, luomeng wrote: >> Hi: >> When the fuzz test injected memory allocation failed, I had this BUG_ON: >> kernel BUG at fs/sysfs/group.c:116. >> The cause of the bug_ON is that the add_disk memory fails to be allocated >> but no error processing is performed. >> I find your patches add error processing. So what is your next step with >> these patches. > I have one more pending series on top of this one I need to submit here: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/alloc_disk > > to make sure the disk always has a valid queue reference. After that > Luis work to return an error from add_disk should be much easier bause > we not have defined state. > . Thanks. So how about this series, when this series will merge into linux master? And do you submit these patches ( http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/alloc_disk) on liunx? Luo Meng