From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 30 Mar 2017 11:06:55 +0200 From: "hch@lst.de" To: Bart Van Assche Cc: "agk@redhat.com" , "lars.ellenberg@linbit.com" , "snitzer@redhat.com" , "hch@lst.de" , "martin.petersen@oracle.com" , "philipp.reisner@linbit.com" , "axboe@kernel.dk" , "shli@kernel.org" , "linux-scsi@vger.kernel.org" , "dm-devel@redhat.com" , "drbd-dev@lists.linbit.com" , "linux-block@vger.kernel.org" , "linux-raid@vger.kernel.org" Subject: Re: [PATCH 23/23] block: remove the discard_zeroes_data flag Message-ID: <20170330090655.GF12015@lst.de> References: <20170323143341.31549-1-hch@lst.de> <20170323143341.31549-24-hch@lst.de> <1490720411.2573.11.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1490720411.2573.11.camel@sandisk.com> List-ID: On Tue, Mar 28, 2017 at 05:00:48PM +0000, Bart Van Assche wrote: > > It seems to me like the documentation in Documentation/ABI/testing/sysfs-block > and the above code are not in sync. I think the above code will cause reading > from the discard_zeroes_data attribute to return an empty string ("") instead > of "0\n". Thanks, fine with me. > > BTW, my personal preference is to remove this attribute entirely because keeping > it will cause confusion, no matter how well we document the behavior of this > attribute. Jens, any opinion? I'd like to remove it too, but I fear it might break things. We could deprecate it first with a warning when read and then remove it a few releases down the road.