From: Minchan Kim <minchan@kernel.org>
To: Jens Axboe <axboe@fb.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinecke <hare@suse.de>, Nitin Gupta <ngupta@vflare.org>,
Christoph Hellwig <hch@lst.de>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
<yizhan@redhat.com>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses
Date: Mon, 3 Apr 2017 14:11:13 +0900 [thread overview]
Message-ID: <20170403051113.GA7096@bbox> (raw)
In-Reply-To: <17796bb7-6657-46d9-9731-d4c0656e6200@fb.com>
Hi Jens,
On Thu, Mar 30, 2017 at 07:38:26PM -0600, Jens Axboe wrote:
> On 03/30/2017 05:45 PM, Minchan Kim wrote:
> > On Thu, Mar 30, 2017 at 09:35:56AM -0600, Jens Axboe wrote:
> >> On 03/30/2017 09:08 AM, Minchan Kim wrote:
> >>> Hi Jens,
> >>>
> >>> It seems you miss this.
> >>> Could you handle this?
> >>
> >> I can, but I'm a little confused. The comment talks about replacing
> >> the one I merged with this one, I can't do that. I'm assuming you
> >> are talking about this commit:
> >
> > Right.
> >
> >>
> >> commit 0bc315381fe9ed9fb91db8b0e82171b645ac008f
> >> Author: Johannes Thumshirn <jthumshirn@suse.de>
> >> Date: Mon Mar 6 11:23:35 2017 +0100
> >>
> >> zram: set physical queue limits to avoid array out of bounds accesses
> >>
> >> which is in mainline. The patch still applies, though.
> >
> > You mean it's already in mainline so you cannot replace but can revert.
> > Right?
> > If so, please revert it and merge this one.
>
> Let's please fold it into the other patch. That's cleaner and it makes
> logical sense.
Understood.
>
> >> Do we really REALLY need this for 4.11, or can we queue for 4.12 and
> >> mark it stable?
> >
> > Not urgent because one in mainline fixes the problem so I'm okay
> > with 4.12 but I don't want mark it as -stable.
>
> OK good, please resend with the two-line revert in your current
> patch, and I'll get it queued up for 4.12.
Yeb. If so, now that I think about it, it would be better to handle
it via Andrew's tree because Andrew have been handled zram's patches
and I have several pending patches based on it.
So, I will send new patchset with it to Andrew.
Thanks!
prev parent reply other threads:[~2017-04-03 5:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 10:23 [PATCH] zram: set physical queue limits to avoid array out of bounds accesses Johannes Thumshirn
2017-03-06 10:25 ` Hannes Reinecke
2017-03-06 10:45 ` Sergey Senozhatsky
2017-03-06 15:21 ` Jens Axboe
2017-03-06 20:18 ` Andrew Morton
2017-03-06 20:19 ` Jens Axboe
2017-03-07 5:22 ` Minchan Kim
2017-03-07 7:00 ` Hannes Reinecke
2017-03-07 7:23 ` Minchan Kim
2017-03-07 7:48 ` Hannes Reinecke
2017-03-07 8:55 ` Minchan Kim
2017-03-07 9:51 ` Johannes Thumshirn
2017-03-08 5:11 ` Minchan Kim
2017-03-08 7:58 ` Johannes Thumshirn
2017-03-09 5:28 ` Minchan Kim
2017-03-30 15:08 ` Minchan Kim
2017-03-30 15:35 ` Jens Axboe
2017-03-30 23:45 ` Minchan Kim
2017-03-31 1:38 ` Jens Axboe
2017-04-03 5:11 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403051113.GA7096@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).