From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 10 Apr 2017 13:21:57 -0700 From: Omar Sandoval To: Bart Van Assche Cc: "linux-block@vger.kernel.org" , "axboe@kernel.dk" Subject: Re: [PATCH 0/2] Export more queue state information through debugfs Message-ID: <20170410202157.GB18846@vader.DHCP.thefacebook.com> References: <20170330182127.24288-1-bart.vanassche@sandisk.com> <826af944-2316-8352-118c-91887d747eca@kernel.dk> <51f5cd27-4ae4-0a21-63e2-c7a2ec95e257@sandisk.com> <20170410200045.GA18846@vader.DHCP.thefacebook.com> <1491855119.4199.21.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1491855119.4199.21.camel@sandisk.com> List-ID: On Mon, Apr 10, 2017 at 08:12:00PM +0000, Bart Van Assche wrote: > On Mon, 2017-04-10 at 13:00 -0700, Omar Sandoval wrote: > > Can you just move blk_queue_flags_fops to blk_mq_debugfs_queue_attrs > > instead of adding blk_queue_attrs? > > Hello Omar, > > Are you aware that that change will move the "state" attribute one level > down in the hierarchy? blk_mq_debugfs_queue_attrs attributes are created > under "mq" while blk_queue_flags_fops attributes are created at the same > level as the "mq" attribute. I had added blk_queue_flags_fops because the > "state" attribute is not related to blk-mq. That attribute is also relevant > for single-queue block layer queues. Yes, I am aware of that. We don't set up debugfs for single-queue queues anyways, so the top-level directory is really just for blktrace. It simplifies the lifetime and cleanup to have everything under mq, so please move it there.