From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:51227 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbeEKGSY (ORCPT ); Fri, 11 May 2018 02:18:24 -0400 Date: Fri, 11 May 2018 08:22:08 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: stop using buffer heads in xfs and iomap Message-ID: <20180511062208.GC7962@lst.de> References: <20180509074830.16196-1-hch@lst.de> <20180510151303.GW11261@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180510151303.GW11261@magnolia> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Thu, May 10, 2018 at 08:13:03AM -0700, Darrick J. Wong wrote: > I ran xfstests on this for fun last night but hung in g/095: > > FSTYP -- xfs (debug) > PLATFORM -- Linux/x86_64 submarine-djwong-mtr01 4.17.0-rc4-djw > MKFS_OPTIONS -- -f -m reflink=1,rmapbt=1, -i sparse=1, -b size=1024, /dev/sdf > MOUNT_OPTIONS -- /dev/sdf /opt > > FWIW the stock v4 and the 'v5 with everything and 4k blocks' vms > passed, so I guess there's a bug somewhere in the sub-page block size > code paths... I haven't seen that in my -b size 1024 -m relink test I'll try your above exact setup, too. Is this disk or SSD? How much memory and how many CPUs? Btw, I think the series might be worthwhile even if we have to delay the sub-page blocksize support - the blocksize == pagesize code is basically entirely separate and already very useful. Only the last three patches contain the small blocksize support, without that we'll just continue using buffer heads for that case for now.