From: Paolo Valente <paolo.valente@linaro.org>
To: Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Angelo Ruocco <angeloruocco90@gmail.com>,
Dennis Zhou <dennis@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Liu Bo <bo.liu@linux.alibaba.com>,
Bart Van Assche <bvanassche@acm.org>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org, bfq-iosched@googlegroups.com,
oleksandr@natalenko.name, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Paolo Valente <paolo.valente@linaro.org>
Subject: [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io
Date: Mon, 19 Nov 2018 11:34:14 +0100 [thread overview]
Message-ID: <20181119103424.3853-1-paolo.valente@linaro.org> (raw)
Hi,
here is the V2 of this patch series. Let me rephrase the description
of the series, in view of the fact that CFQ will be gone with legacy
block.
The current implementation of cgroups doesn't allow two or more
entities, e.g., I/O schedulers, to share the same files. Thus, to
enable people to set group weights with BFQ, I resorted to making BFQ
create its own version of the same interface files used by CFQ (before
going away with legacy block), by prepending a bfq prefix.
Actually, no legacy code uses these different names, or is likely to
do so. Having these two sets of names is simply a source of
confusion, as pointed out also, e.g., by Lennart Poettering (CCed
here), and acknowledged by Tejun [2].
In [1] we agreed on a solution that solves this problem, by actually
making it possible to share cgroups files. Both writing to and
reading from a shared file trigger the appropriate operation for each
of the entities that share the file. In particular, in case of
reading,
- if all entities produce the same output, the this common output is
shown only once;
- if the outputs differ, then every per-entity output is shown,
followed by the name of the entity that produced that output.
With this solution, legacy code that, e.g., sets group weights, just
works, regardless of the I/O scheduler actually implementing
proportional share.
But note that this extension is not restricted to only blkio/io. The
general group interface now enables files to be shared among multiple
entities of any kind.
(I have also added a patch to fix some clerical errors in bfq doc,
which I found while making the latter consistent with the new
interface.)
CHANGES FROM V1:
- Removed patch that introduced a function to only find kernfs nodes,
without increasing ref counters
- Changed commit messages and BFQ documentation, to comply with the
fact that there won't be CFQ any longer
Thanks,
Paolo
Angelo Ruocco (5):
cgroup: link cftypes of the same subsystem with the same name
cgroup: add owner name to cftypes
block, bfq: align min and default weights with the old cfq default
cgroup: make all functions of all cftypes be invoked
block, throttle: allow sharing cgroup statistic files
Paolo Valente (5):
cgroup: add hook seq_show_cft with also the owning cftype as parameter
block, cgroup: pass cftype to functions that need to use it
block, bfq: use standard file names for the proportional-share policy
doc, bfq-iosched: fix a few clerical errors
doc, bfq-iosched: make it consistent with the new cgroup interface
Documentation/block/bfq-iosched.txt | 34 ++---
block/bfq-cgroup.c | 148 +++++++++++++-------
block/bfq-iosched.h | 4 +-
block/blk-cgroup.c | 22 +--
block/blk-throttle.c | 24 ++--
include/linux/blk-cgroup.h | 10 +-
include/linux/cgroup-defs.h | 14 +-
include/linux/cgroup.h | 13 ++
kernel/cgroup/cgroup.c | 262 +++++++++++++++++++++++++++++-------
9 files changed, 390 insertions(+), 141 deletions(-)
--
2.16.1
next reply other threads:[~2018-11-19 10:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:34 Paolo Valente [this message]
2018-11-19 10:34 ` [PATCH V2 01/10] cgroup: add hook seq_show_cft with also the owning cftype as parameter Paolo Valente
2018-11-19 10:34 ` [PATCH V2 02/10] block, cgroup: pass cftype to functions that need to use it Paolo Valente
2018-11-19 10:34 ` [PATCH V2 03/10] cgroup: link cftypes of the same subsystem with the same name Paolo Valente
2018-11-19 10:34 ` [PATCH V2 04/10] cgroup: add owner name to cftypes Paolo Valente
2018-11-19 10:34 ` [PATCH V2 05/10] block, bfq: align min and default weights with the old cfq default Paolo Valente
2018-11-19 10:34 ` [PATCH V2 06/10] cgroup: make all functions of all cftypes be invoked Paolo Valente
2018-11-19 10:34 ` [PATCH V2 07/10] block, bfq: use standard file names for the proportional-share policy Paolo Valente
2018-11-19 10:34 ` [PATCH V2 08/10] block, throttle: allow sharing cgroup statistic files Paolo Valente
2018-11-19 10:34 ` [PATCH V2 09/10] doc, bfq-iosched: fix a few clerical errors Paolo Valente
2018-11-19 10:34 ` [PATCH V2 10/10] doc, bfq-iosched: make it consistent with the new cgroup interface Paolo Valente
2018-11-20 16:28 ` [PATCH V2 00/10] unify the interface of the proportional-share policy in blkio/io Tejun Heo
2018-11-20 16:50 ` Paolo Valente
2018-11-30 18:23 ` Paolo Valente
2018-11-30 18:42 ` Tejun Heo
2018-11-30 18:53 ` Paolo Valente
2018-12-10 13:45 ` Angelo Ruocco
2018-12-18 7:48 ` Paolo Valente
2018-12-18 16:41 ` Tejun Heo
2018-12-18 17:22 ` Paolo Valente
2018-12-18 18:05 ` Paolo Valente
2018-12-23 11:00 ` Paolo Valente
2018-12-27 23:41 ` Tejun Heo
2018-12-30 10:25 ` Paolo Valente
2019-01-02 16:03 ` Tejun Heo
2019-01-02 16:28 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119103424.3853-1-paolo.valente@linaro.org \
--to=paolo.valente@linaro.org \
--cc=angeloruocco90@gmail.com \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=bo.liu@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dennis@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=oleksandr@natalenko.name \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).