From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3853C04EB8 for ; Thu, 6 Dec 2018 19:04:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B60CA20989 for ; Thu, 6 Dec 2018 19:04:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B60CA20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725958AbeLFTEt (ORCPT ); Thu, 6 Dec 2018 14:04:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59044 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbeLFTEs (ORCPT ); Thu, 6 Dec 2018 14:04:48 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92480C051663; Thu, 6 Dec 2018 19:04:48 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E48FD5D76B; Thu, 6 Dec 2018 19:04:45 +0000 (UTC) Date: Thu, 6 Dec 2018 14:04:45 -0500 From: Mike Snitzer To: Jens Axboe , Omar Sandoval Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, Mikulas Patocka Subject: Re: [PATCH v4 0/7] per-cpu in_flight counters for bio-based drivers Message-ID: <20181206190444.GA15753@redhat.com> References: <20181206164122.2166-1-snitzer@redhat.com> <20181206180025.GA15514@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181206180025.GA15514@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 06 Dec 2018 19:04:48 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Dec 06 2018 at 1:00pm -0500, Mike Snitzer wrote: > On Thu, Dec 06 2018 at 11:41am -0500, > Mike Snitzer wrote: > > > Hey, > > > > This v4 addresses the compile issues on various archs when CONFIG_SMP > > isn't set (by introducing appropriate wrappers in genhd.h) > > > > Testing with this v4 I was unable to reproduce the issue you reported > > where iostat always reports 0 for avgqu-sz -- but please let me know > > if you still see problems like that. > > I ran blktests and both block/017 and block/018 fail due to this > patchset's changes, I'm still trying to grok what the test result is > _saying_ but I'll hopefully get there soon: > > block/017 (do I/O and check the inflight counter) [failed] > runtime ... 77.675s > --- tests/block/017.out 2018-12-06 12:31:21.457936217 -0500 > +++ /home/git/blktests/results/nodev/block/017.out.bad 2018-12-06 12:36:15.735053586 -0500 > @@ -1,14 +1,14 @@ > Running block/017 > -sysfs inflight reads 1 > +sysfs inflight reads 2 > sysfs inflight writes 0 > -sysfs stat 1 > -diskstats 1 > -sysfs inflight reads 1 > ... > (Run 'diff -u tests/block/017.out /home/git/blktests/results/nodev/block/017.out.bad' to see the entire diff) > > # diff -u tests/block/017.out /home/git/blktests/results/nodev/block/017.out.bad > --- tests/block/017.out 2018-12-06 12:31:21.457936217 -0500 > +++ /home/git/blktests/results/nodev/block/017.out.bad 2018-12-06 12:51:36.695542332 -0500 > @@ -1,14 +1,14 @@ > Running block/017 > -sysfs inflight reads 1 > +sysfs inflight reads 2 > sysfs inflight writes 0 > -sysfs stat 1 > -diskstats 1 > -sysfs inflight reads 1 > -sysfs inflight writes 1 > sysfs stat 2 > diskstats 2 > -sysfs inflight reads 0 > +sysfs inflight reads 2 > +sysfs inflight writes 1 > +sysfs stat 3 > +diskstats 3 > +sysfs inflight reads 1 > sysfs inflight writes 0 > -sysfs stat 0 > -diskstats 0 > +sysfs stat 1 > +diskstats 1 > Test complete > Interestingly the 017 test is only testing blk-mq (using null_blk's queue_mode=2). This patchset's changes are specific to bio-based. If I revert this patchset I still get the failures. So it would seem something regressed in latest block for-next (I've been testing up through linux-block commit c754a9bf7ee8 ("blk-mq: remove QUEUE_FLAG_POLL from default MQ flags"). > block/018 (do I/O and check iostats times) [failed] > runtime ... 156.073s > --- tests/block/018.out 2018-12-06 12:31:21.458936217 -0500 > +++ /home/git/blktests/results/nodev/block/018.out.bad 2018-12-06 12:38:51.831116369 -0500 > @@ -1,10 +1,10 @@ > Running block/018 > read 0 s > write 0 s > -read 1 s > +read 2 s > write 0 s > -read 1 s > ... > (Run 'diff -u tests/block/018.out /home/git/blktests/results/nodev/block/018.out.bad' to see the entire diff) > > # diff -u tests/block/018.out /home/git/blktests/results/nodev/block/018.out.bad > --- tests/block/018.out 2018-12-06 12:31:21.458936217 -0500 > +++ /home/git/blktests/results/nodev/block/018.out.bad 2018-12-06 12:38:51.831116369 -0500 > @@ -1,10 +1,10 @@ > Running block/018 > read 0 s > write 0 s > -read 1 s > +read 2 s > write 0 s > -read 1 s > -write 1 s > read 2 s > +write 1 s > +read 6 s > write 3 s > Test complete Same goes for this block/018 test. Mike