From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C46C65BAE for ; Thu, 13 Dec 2018 20:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82B7620851 for ; Thu, 13 Dec 2018 20:20:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82B7620851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726355AbeLMUUS (ORCPT ); Thu, 13 Dec 2018 15:20:18 -0500 Received: from verein.lst.de ([213.95.11.211]:43092 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727417AbeLMUUS (ORCPT ); Thu, 13 Dec 2018 15:20:18 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id ECA4468DD6; Thu, 13 Dec 2018 21:20:16 +0100 (CET) Date: Thu, 13 Dec 2018 21:20:16 +0100 From: Christoph Hellwig To: Thadeu Lima de Souza Cascardo Cc: Christoph Hellwig , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 4/4] block: expose devt for GENHD_FL_HIDDEN disks Message-ID: <20181213202016.GA15992@lst.de> References: <20181206164812.30925-1-cascardo@canonical.com> <20181206164812.30925-5-cascardo@canonical.com> <20181213143218.GA8723@lst.de> <20181213152532.GA5321@calabresa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213152532.GA5321@calabresa> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Dec 13, 2018 at 01:25:33PM -0200, Thadeu Lima de Souza Cascardo wrote: > > And I've checked back - lsblk actually works just fine at the moment. > > But it turns out once we create the slave links it stops working, > > which is a really good argument against the first two patches, which > > would otherwise seem nice.. > > Which is why I have sent the "paths/" patchset in the first place. Because I > did some homework and read the previous discussion about this, and how lsblk > failure to behave with slave links led to the revert of the slaves/holders > patch by Dr. Hannes. Sorry, I did not actually notice that Hannes patch manually created the same slaves/holders link we otherwise create using the block layer APIs. Had I realized those actually were the same that had saved me some work. So I guess the v2 paths/ link patch from you is the least of all evils. Hannes, can you look over that one?