From: Damien Le Moal <damien.lemoal@wdc.com>
To: linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
Masato Suzuki <masato.suzuki@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Omar Sandoval <osandov@osandov.com>, Jens Axboe <axboe@kernel.dk>,
Matias Bjorling <matias.bjorling@wdc.com>,
Hannes Reinecke <hare@suse.de>, Mike Snitzer <snitzer@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH blktests 14/14] zbd/005: Test write ordering
Date: Wed, 9 Jan 2019 10:35:42 +0900 [thread overview]
Message-ID: <20190109013542.23686-15-damien.lemoal@wdc.com> (raw)
In-Reply-To: <20190109013542.23686-1-damien.lemoal@wdc.com>
From: Masato Suzuki <masato.suzuki@wdc.com>
Run a high queue depth direct sequential write fio job to check that
write requests are not being reordered when the deadline scheduler is
used. This test allowed to catch a bug fixed with commit
80e02039721 "block: mq-deadline: Fix write completion handling".
Signed-off-by: Masato Suzuki <masato.suzuki@wdc.com>
---
tests/zbd/005 | 57 +++++++++++++++++++++++++++++++++++++++++++++++
tests/zbd/005.out | 2 ++
2 files changed, 59 insertions(+)
create mode 100755 tests/zbd/005
create mode 100644 tests/zbd/005.out
diff --git a/tests/zbd/005 b/tests/zbd/005
new file mode 100755
index 0000000..7b38462
--- /dev/null
+++ b/tests/zbd/005
@@ -0,0 +1,57 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2018 Western Digital Corporation or its affiliates.
+#
+# Test zoned block device write ordering. Run simultaneous write operations
+# to a single zone and confirm no write ordering failure.
+# It checks fix by commit 80e02039721 ("block: mq-deadline: Fix write
+# completion handling").
+
+. tests/zbd/rc
+
+DESCRIPTION="write command ordering"
+TIMED=1
+
+requires() {
+ _have_fio
+}
+
+_find_first_sequential_zone() {
+ for ((idx = NR_CONV_ZONES; idx < REPORTED_COUNT; idx++)); do
+ if [[ ${ZONE_TYPES[idx]} -eq ${ZONE_TYPE_SEQ_WRITE_REQUIRED} ]];
+ then
+ echo "${idx}"
+ return 0
+ fi
+ done
+ echo "Sequential write required zone not found"
+
+ return 1
+}
+
+test_device() {
+ local -i zone_idx
+ local -i offset
+
+ echo "Running ${TEST_NAME}"
+
+ _get_sysfs_variable "${TEST_DEV}" || return $?
+ _get_blkzone_report "${TEST_DEV}" || return $?
+
+ zone_idx=$(_find_first_sequential_zone) || return $?
+ offset=$((ZONE_STARTS[zone_idx] * 512))
+
+ blkzone reset -o "${ZONE_STARTS[zone_idx]}" "${TEST_DEV}"
+
+ : "${TIMEOUT:=30}"
+ set_scheduler "$(basename "$(readlink -f "${TEST_DEV}")")" deadline
+ FIO_PERF_FIELDS=("write io" "write iops")
+ _fio_perf --filename="${TEST_DEV}" --name zbdwo --rw=write --direct=1 \
+ --ioengine=libaio --iodepth=128 --bs=256k \
+ --offset="${offset}"
+
+ _put_blkzone_report
+ _put_sysfs_variable
+
+ echo "Test complete"
+}
diff --git a/tests/zbd/005.out b/tests/zbd/005.out
new file mode 100644
index 0000000..3ff78c6
--- /dev/null
+++ b/tests/zbd/005.out
@@ -0,0 +1,2 @@
+Running zbd/005
+Test complete
--
2.20.1
prev parent reply other threads:[~2019-01-09 1:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 1:35 [PATCH blktests 00/14] Implement zoned block device support Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 01/14] config: Introduce ZONED variable Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 02/14] common: Introduce _test_dev_is_zoned() helper function Damien Le Moal
2019-01-09 8:46 ` Johannes Thumshirn
2019-01-09 1:35 ` [PATCH blktests 03/14] common: Move set_scheduler() function from multipath-over-rdma to rc Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 04/14] block/004: Adjust fio conditions for zoned block device Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 05/14] block/013: Skip for zoned block devices Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 06/14] block/018,024: Skip when ZONED is set Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 07/14] check: Introduce group_exit() function Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 08/14] src: Introduce zbdioctl program Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 09/14] tests: Introduce zbd test group Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 10/14] zbd/001: sysfs and ioctl consistency test Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 11/14] zbd/002: report zone test Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 12/14] zbd/003: Test sequential zones reset Damien Le Moal
2019-01-09 1:35 ` [PATCH blktests 13/14] zbd/004: Check write split accross sequential zones Damien Le Moal
2019-01-09 1:35 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109013542.23686-15-damien.lemoal@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masato.suzuki@wdc.com \
--cc=matias.bjorling@wdc.com \
--cc=osandov@fb.com \
--cc=osandov@osandov.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).