From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-block@vger.kernel.org, linux-arch@vger.kernel.org
Cc: hch@lst.de, jmoyer@redhat.com, avi@scylladb.com,
Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 10/15] io_uring: batch io_kiocb allocation
Date: Wed, 9 Jan 2019 19:43:59 -0700 [thread overview]
Message-ID: <20190110024404.25372-11-axboe@kernel.dk> (raw)
In-Reply-To: <20190110024404.25372-1-axboe@kernel.dk>
Similarly to how we use the state->ios_left to know how many references
to get to a file, we can use it to allocate the io_kiocb's we need in
bulk.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
fs/io_uring.c | 71 +++++++++++++++++++++++++++++++++++++--------------
1 file changed, 52 insertions(+), 19 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index cd2dfc153338..b5233786b5a8 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -127,6 +127,13 @@ struct io_submit_state {
struct list_head req_list;
unsigned int req_count;
+ /*
+ * io_kiocb alloc cache
+ */
+ void *kiocbs[IO_IOPOLL_BATCH];
+ unsigned int free_kiocbs;
+ unsigned int cur_kiocb;
+
/*
* File reference cache
*/
@@ -196,36 +203,58 @@ static struct io_uring_cqe *io_peek_cqring(struct io_ring_ctx *ctx)
return &ring->cqes[tail & ctx->cq_mask];
}
-static struct io_kiocb *io_get_kiocb(struct io_ring_ctx *ctx)
+static void io_ring_drop_ctx_refs(struct io_ring_ctx *ctx, unsigned refs)
+{
+ percpu_ref_put_many(&ctx->refs, refs);
+
+ if (waitqueue_active(&ctx->wait))
+ wake_up(&ctx->wait);
+}
+
+static struct io_kiocb *io_get_kiocb(struct io_ring_ctx *ctx,
+ struct io_submit_state *state)
{
struct io_kiocb *req;
if (!percpu_ref_tryget(&ctx->refs))
return NULL;
- req = kmem_cache_alloc(kiocb_cachep, GFP_KERNEL);
- if (!req)
- return NULL;
-
- req->ki_ctx = ctx;
- INIT_LIST_HEAD(&req->ki_list);
- req->ki_flags = 0;
- return req;
-}
+ if (!state)
+ req = kmem_cache_alloc(kiocb_cachep, GFP_KERNEL);
+ else if (!state->free_kiocbs) {
+ size_t sz;
+ int ret;
+
+ sz = min_t(size_t, state->ios_left, ARRAY_SIZE(state->kiocbs));
+ ret = kmem_cache_alloc_bulk(kiocb_cachep, GFP_KERNEL, sz,
+ state->kiocbs);
+ if (ret <= 0)
+ goto out;
+ state->free_kiocbs = ret - 1;
+ state->cur_kiocb = 1;
+ req = state->kiocbs[0];
+ } else {
+ req = state->kiocbs[state->cur_kiocb];
+ state->free_kiocbs--;
+ state->cur_kiocb++;
+ }
-static void io_ring_drop_ctx_ref(struct io_ring_ctx *ctx, unsigned refs)
-{
- percpu_ref_put_many(&ctx->refs, refs);
+ if (req) {
+ req->ki_ctx = ctx;
+ req->ki_flags = 0;
+ return req;
+ }
- if (waitqueue_active(&ctx->wait))
- wake_up(&ctx->wait);
+out:
+ io_ring_drop_ctx_refs(ctx, 1);
+ return NULL;
}
static void io_free_kiocb_many(struct io_ring_ctx *ctx, void **iocbs, int *nr)
{
if (*nr) {
kmem_cache_free_bulk(kiocb_cachep, *nr, iocbs);
- io_ring_drop_ctx_ref(ctx, *nr);
+ io_ring_drop_ctx_refs(ctx, *nr);
*nr = 0;
}
}
@@ -233,7 +262,7 @@ static void io_free_kiocb_many(struct io_ring_ctx *ctx, void **iocbs, int *nr)
static void io_free_kiocb(struct io_kiocb *iocb)
{
kmem_cache_free(kiocb_cachep, iocb);
- io_ring_drop_ctx_ref(iocb->ki_ctx, 1);
+ io_ring_drop_ctx_refs(iocb->ki_ctx, 1);
}
/*
@@ -761,7 +790,7 @@ static int io_submit_sqe(struct io_ring_ctx *ctx, struct sqe_submit *s,
if (unlikely(sqe->flags))
return -EINVAL;
- req = io_get_kiocb(ctx);
+ req = io_get_kiocb(ctx, state);
if (unlikely(!req))
return -EAGAIN;
@@ -828,6 +857,9 @@ static void io_submit_state_end(struct io_submit_state *state)
if (!list_empty(&state->req_list))
io_flush_state_reqs(state->ctx, state);
io_file_put(state, NULL);
+ if (state->free_kiocbs)
+ kmem_cache_free_bulk(kiocb_cachep, state->free_kiocbs,
+ &state->kiocbs[state->cur_kiocb]);
}
/*
@@ -839,6 +871,7 @@ static void io_submit_state_start(struct io_submit_state *state,
state->ctx = ctx;
INIT_LIST_HEAD(&state->req_list);
state->req_count = 0;
+ state->free_kiocbs = 0;
state->file = NULL;
state->ios_left = max_ios;
#ifdef CONFIG_BLOCK
@@ -1071,7 +1104,7 @@ SYSCALL_DEFINE4(io_uring_enter, unsigned int, fd, u32, to_submit,
ret = __io_uring_enter(ctx, to_submit, min_complete, flags);
mutex_unlock(&ctx->uring_lock);
}
- io_ring_drop_ctx_ref(ctx, 1);
+ io_ring_drop_ctx_refs(ctx, 1);
out_fput:
fdput(f);
return ret;
--
2.17.1
next prev parent reply other threads:[~2019-01-10 2:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 2:43 [PATCHSET v2] io_uring IO interface Jens Axboe
2019-01-10 2:43 ` [PATCH 01/15] fs: add an iopoll method to struct file_operations Jens Axboe
2019-01-10 2:43 ` [PATCH 02/15] block: wire up block device iopoll method Jens Axboe
2019-01-10 2:43 ` [PATCH 03/15] block: add bio_set_polled() helper Jens Axboe
2019-01-10 2:43 ` [PATCH 04/15] iomap: wire up the iopoll method Jens Axboe
2019-01-10 2:43 ` [PATCH 05/15] Add io_uring IO interface Jens Axboe
2019-01-11 18:19 ` Martin K. Petersen
2019-01-11 18:34 ` Jens Axboe
2019-01-13 16:22 ` Jens Axboe
2019-01-15 17:31 ` Martin K. Petersen
2019-01-10 2:43 ` [PATCH 06/15] io_uring: support for IO polling Jens Axboe
2019-01-10 2:43 ` [PATCH 07/15] io_uring: add submission side request cache Jens Axboe
2019-01-10 2:43 ` [PATCH 08/15] fs: add fget_many() and fput_many() Jens Axboe
2019-01-10 2:43 ` [PATCH 09/15] io_uring: use fget/fput_many() for file references Jens Axboe
2019-01-10 2:43 ` Jens Axboe [this message]
2019-01-10 2:44 ` [PATCH 11/15] block: implement bio helper to add iter bvec pages to bio Jens Axboe
2019-01-10 2:44 ` [PATCH 12/15] io_uring: add support for pre-mapped user IO buffers Jens Axboe
2019-01-10 2:44 ` [PATCH 13/15] io_uring: support kernel side submission Jens Axboe
2019-01-10 2:44 ` [PATCH 14/15] io_uring: add submission polling Jens Axboe
2019-01-10 2:44 ` [PATCH 15/15] io_uring: add io_uring_event cache hit information Jens Axboe
2019-01-10 23:12 ` Jeff Moyer
2019-01-10 23:47 ` Jens Axboe
2019-01-11 9:46 ` [PATCHSET v2] io_uring IO interface Roman Penyaev
2019-01-11 16:11 ` Ilya Dryomov
2019-01-11 16:21 ` Christoph Hellwig
2019-01-11 16:39 ` Roman Penyaev
2019-01-11 18:05 ` Jens Axboe
2019-01-16 17:49 [PATCHSET v5] " Jens Axboe
2019-01-16 17:49 ` [PATCH 10/15] io_uring: batch io_kiocb allocation Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110024404.25372-11-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=avi@scylladb.com \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).