From: Coly Li <colyli@suse.de>
To: axboe@kernel.dk
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
Coly Li <colyli@suse.de>
Subject: [PATCH 10/19] bcache: add sysfs_strtoul_bool() for setting bit-field variables
Date: Sat, 9 Feb 2019 12:53:02 +0800 [thread overview]
Message-ID: <20190209045311.15677-11-colyli@suse.de> (raw)
In-Reply-To: <20190209045311.15677-1-colyli@suse.de>
When setting bool values via sysfs interface, e.g. writeback_metadata,
if writing 1 into writeback_metadata file, dc->writeback_metadata is
set to 1, but if writing 2 into the file, dc->writeback_metadata is
0. This is misleading, a better result should be 1 for all non-zero
input value.
It is because dc->writeback_metadata is a bit-field variable, and
current code simply use d_strtoul() to convert a string into integer
and takes the lowest bit value. To fix such error, we need a routine
to convert the input string into unsigned integer, and set target
variable to 1 if the converted integer is non-zero.
This patch introduces a new macro called sysfs_strtoul_bool(), it can
be used to convert input string into bool value, we can use it to set
bool value for bit-field vairables.
Signed-off-by: Coly Li <colyli@suse.de>
---
drivers/md/bcache/sysfs.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/md/bcache/sysfs.h b/drivers/md/bcache/sysfs.h
index 0ad2715a884e..215df32f567b 100644
--- a/drivers/md/bcache/sysfs.h
+++ b/drivers/md/bcache/sysfs.h
@@ -79,6 +79,16 @@ do { \
return strtoul_safe(buf, var) ?: (ssize_t) size; \
} while (0)
+#define sysfs_strtoul_bool(file, var) \
+do { \
+ if (attr == &sysfs_ ## file) { \
+ unsigned long v = strtoul_or_return(buf); \
+ \
+ var = v ? 1 : 0; \
+ return size; \
+ } \
+} while (0)
+
#define sysfs_strtoul_clamp(file, var, min, max) \
do { \
if (attr == &sysfs_ ## file) { \
--
2.16.4
next prev parent reply other threads:[~2019-02-09 4:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 4:52 [PATCH 00/19] bcache patches for Linux v5.1 Coly Li
2019-02-09 4:52 ` [PATCH 01/19] bcache: never writeback a discard operation Coly Li
2019-02-09 4:52 ` [PATCH 02/19] bcache: not use hard coded memset size in bch_cache_accounting_clear() Coly Li
2019-02-09 4:52 ` [PATCH 03/19] bcache: export backing_dev_name via sysfs Coly Li
2019-02-09 4:52 ` [PATCH 04/19] bcache: export backing_dev_uuid " Coly Li
2019-02-09 4:52 ` [PATCH 05/19] bcache: fix indentation issue, remove tabs on a hunk of code Coly Li
2019-02-09 4:52 ` [PATCH 06/19] bcache: treat stale && dirty keys as bad keys Coly Li
[not found] ` <20190212132825.E476F217D9@mail.kernel.org>
2019-02-12 16:42 ` Coly Li
2019-02-09 4:52 ` [PATCH 07/19] bcache: improve sysfs_strtoul_clamp() Coly Li
2019-02-09 4:53 ` [PATCH 08/19] bcache: fix input integer overflow of congested threshold Coly Li
2019-02-09 4:53 ` [PATCH 09/19] bcache: fix input overflow to sequential_cutoff Coly Li
2019-02-09 4:53 ` Coly Li [this message]
2019-02-09 4:53 ` [PATCH 11/19] bcache: use sysfs_strtoul_bool() to set bit-field variables Coly Li
2019-02-09 4:53 ` [PATCH 12/19] bcache: fix input overflow to writeback_delay Coly Li
2019-02-09 4:53 ` [PATCH 13/19] bcache: fix potential div-zero error of writeback_rate_i_term_inverse Coly Li
2019-02-09 4:53 ` [PATCH 14/19] bcache: fix potential div-zero error of writeback_rate_p_term_inverse Coly Li
2019-02-09 4:53 ` [PATCH 15/19] bcache: fix input overflow to writeback_rate_minimum Coly Li
2019-02-09 4:53 ` [PATCH 16/19] bcache: fix input overflow to journal_delay_ms Coly Li
2019-02-09 4:53 ` [PATCH 17/19] bcache: fix input overflow to cache set io_error_limit Coly Li
2019-02-09 4:53 ` [PATCH 18/19] bcache: fix input overflow to cache set sysfs file io_error_halflife Coly Li
2019-02-09 4:53 ` [PATCH 19/19] bcache: use (REQ_META|REQ_PRIO) to indicate bio for metadata Coly Li
[not found] ` <20190212132824.1D1502084E@mail.kernel.org>
2019-02-12 16:48 ` Coly Li
2019-02-09 14:19 ` [PATCH 00/19] bcache patches for Linux v5.1 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209045311.15677-11-colyli@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).