From: "Matias Bjørling" <mb@lightnvm.io>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Hans Holmberg" <hans.holmberg@cnexlabs.com>,
"Matias Bjørling" <mb@lightnvm.io>
Subject: [GIT PULL 2/8] lightnvm: pblk: use vfree to free metadata on error path
Date: Mon, 11 Feb 2019 13:25:03 +0100 [thread overview]
Message-ID: <20190211122509.19910-3-mb@lightnvm.io> (raw)
In-Reply-To: <20190211122509.19910-1-mb@lightnvm.io>
From: Hans Holmberg <hans.holmberg@cnexlabs.com>
As chunk metadata is allocated using vmalloc, we need to free it
using vfree.
Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page")
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
---
drivers/lightnvm/pblk-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 1ff165351180..1b5ff51faa63 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -141,7 +141,7 @@ struct nvm_chk_meta *pblk_get_chunk_meta(struct pblk *pblk)
ret = nvm_get_chunk_meta(dev, ppa, geo->all_chunks, meta);
if (ret) {
- kfree(meta);
+ vfree(meta);
return ERR_PTR(-EIO);
}
--
2.19.1
next prev parent reply other threads:[~2019-02-11 12:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 12:25 [GIT PULL 0/8] lightnvm updates for 5.1 Matias Bjørling
2019-02-11 12:25 ` [GIT PULL 1/8] lightnvm: pblk: stop taking the free lock in in pblk_lines_free Matias Bjørling
2019-02-11 12:25 ` Matias Bjørling [this message]
2019-02-11 12:25 ` [GIT PULL 3/8] lightnvm: Use u64 instead of __le64 for CPU visible side Matias Bjørling
2019-02-11 12:25 ` [GIT PULL 4/8] lightnvm: pblk: Switch to use new generic UUID API Matias Bjørling
2019-02-11 12:25 ` [GIT PULL 5/8] lightnvm: pblk: fix TRACE_INCLUDE_PATH Matias Bjørling
2019-02-11 12:25 ` [GIT PULL 6/8] lightnvm: pblk: extend line wp balance check Matias Bjørling
2019-02-11 12:25 ` [GIT PULL 7/8] lightnvm: pblk: prevent stall due to wb threshold Matias Bjørling
2019-02-11 12:25 ` [GIT PULL 8/8] lightnvm: pblk: fix race condition on GC Matias Bjørling
2019-02-11 15:22 ` [GIT PULL 0/8] lightnvm updates for 5.1 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211122509.19910-3-mb@lightnvm.io \
--to=mb@lightnvm.io \
--cc=axboe@fb.com \
--cc=hans.holmberg@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).