linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: queue flag cleanup
Date: Tue, 12 Feb 2019 00:09:41 -0800	[thread overview]
Message-ID: <20190212080941.GB1807@infradead.org> (raw)
In-Reply-To: <20190209224424.7560-3-axboe@kernel.dk>

On Sat, Feb 09, 2019 at 03:44:24PM -0700, Jens Axboe wrote:
> We have QUEUE_FLAG_DEFAULT defined, but it's not used anymore since
> the legacy IO stack is gone. Kill it.
> 
> Sanitize the queue flags in general, they use spaces (for some
> reason), and the space is pretty sparse. With the flags renumbered,
> we can more clearly see how many we have available.
> 
> Signed-off-by: Jens Axboe <axboe@kernel.dk>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Btw, I think we should kill off QUEUE_FLAG_MQ_DEFAULT as well and open
code it in blk_mq_init_allocated_queue instead.

      reply	other threads:[~2019-02-12  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 22:44 [PATCHSET] Sanitize queue flags Jens Axboe
2019-02-09 22:44 ` [PATCH 1/2] block: kill QUEUE_FLAG_FLUSH_NQ Jens Axboe
2019-02-12  8:08   ` Christoph Hellwig
2019-02-09 22:44 ` [PATCH 2/2] block: queue flag cleanup Jens Axboe
2019-02-12  8:09   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212080941.GB1807@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).