From: Ming Lei <ming.lei@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Dongli Zhang <dongli.zhang@oracle.com>,
fin4478 fin4478 <fin4478@hotmail.com>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"axboe@fb.com" <axboe@fb.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: A kernel warning when entering suspend
Date: Fri, 5 Apr 2019 06:50:15 +0800 [thread overview]
Message-ID: <20190404225014.GB31281@ming.t460p> (raw)
In-Reply-To: <20190404222955.GA25081@localhost.localdomain>
On Thu, Apr 04, 2019 at 04:29:56PM -0600, Keith Busch wrote:
> On Fri, Apr 05, 2019 at 06:19:50AM +0800, Ming Lei wrote:
> > Also in current blk-mq implementation, one irq may become shutdown
> > because of CPU hotplug even though when there is in-flight request
> > on the queue served by the irq. Then we depend on timeout handler to
> > cover this case, and this irq may be enabled in the timeout handler too,
> > please see nvme_poll_irqdisable().
>
> Right, but when the last CPU mapped to an hctx is taken offline, we really
> ought to have blk-mq wait for that hctx to reap all outstanding requests
> before letting the notifier continue with offlining that CPU. We just
> don't have the infrastructure to freeze an individual hctx yet.
Looks this issue isn't unique for storage device, anyone knows how other
device drivers deal with this situation? For example, one network packet is
submitted to NIC controller and not got completed, then the interrupt
may become down because of CPU hotplug.
Thanks,
Ming
next parent reply other threads:[~2019-04-04 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AM6PR06MB50637026B0E7D87341BF47A3A1500@AM6PR06MB5063.eurprd06.prod.outlook.com>
[not found] ` <20190404085524.GA24927@ming.t460p>
[not found] ` <dbc75de4-aefc-b7da-e86a-91da37f463cf@oracle.com>
[not found] ` <alpine.DEB.2.21.1904041812350.1802@nanos.tec.linutronix.de>
[not found] ` <20190404221948.GB30656@ming.t460p>
[not found] ` <20190404222955.GA25081@localhost.localdomain>
2019-04-04 22:50 ` Ming Lei [this message]
2019-04-05 11:35 ` A kernel warning when entering suspend Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404225014.GB31281@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=dongli.zhang@oracle.com \
--cc=fin4478@hotmail.com \
--cc=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).