From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A7BC43219 for ; Sat, 4 May 2019 12:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92F8020644 for ; Sat, 4 May 2019 12:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbfEDMdL (ORCPT ); Sat, 4 May 2019 08:33:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:32952 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725981AbfEDMdK (ORCPT ); Sat, 4 May 2019 08:33:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E45FEAD26; Sat, 4 May 2019 12:33:09 +0000 (UTC) Date: Sat, 4 May 2019 14:33:09 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org Subject: Re: [PATCH 4/8] iomap: use bio_release_pages in iomap_dio_bio_end_io Message-ID: <20190504123309.GC5329@x250> References: <20190502233332.28720-1-hch@lst.de> <20190502233332.28720-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190502233332.28720-5-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, May 02, 2019 at 07:33:28PM -0400, Christoph Hellwig wrote: > @@ -1588,13 +1588,7 @@ static void iomap_dio_bio_end_io(struct bio *bio) > if (should_dirty) { > bio_check_pages_dirty(bio); > } else { > - if (!bio_flagged(bio, BIO_NO_PAGE_REF)) { > - struct bvec_iter_all iter_all; > - struct bio_vec *bvec; > - > - bio_for_each_segment_all(bvec, bio, iter_all) > - put_page(bvec->bv_page); > - } > + bio_release_pages(bio); Shouldn't this rather be: if (!bio_flagged(bio, BIO_NO_PAGE_REF)) bio_release_pages(bio); -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850