From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1333C072B5 for ; Fri, 24 May 2019 13:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FE9921773 for ; Fri, 24 May 2019 13:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="y7nfCg4b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403797AbfEXNHq (ORCPT ); Fri, 24 May 2019 09:07:46 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:33684 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391440AbfEXNHp (ORCPT ); Fri, 24 May 2019 09:07:45 -0400 Received: by mail-vk1-f194.google.com with SMTP id v69so2115011vke.0 for ; Fri, 24 May 2019 06:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jdBUUMv99kj0cqC35xVQ0vJ+lTbAYnC4lk5/+dSwqX8=; b=y7nfCg4b4hWh5cXtClN2G9IlPfZtmsJ3lCmnJcQFhJJFfR7Duny76GHmGWVmLX7JkN 4BQJt1/DlmVVHNx6yxD8f1v1vebpwhOW/ZIYNZ2RvPKxui5ELigztwF3+awy6EBQw7wE m3Y2E5XpbLeF2AxgqwDhp4aX77GeAAP51wkhJr9AxhH+GkIXWwNH8VLVQGaBoN8GvqUp A8Sh1fZjhD6lSYCc2m9pwMqc/p7T2nlHT50o9OXZ1RUVaIxCKjYUX676pmynjMX0a5ue bReHsYh0ssps55JEZQvYZbYbEun8Ea/68G3H264PjF491twDM4RQQrC4Rib1pUZoFXKT CZ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jdBUUMv99kj0cqC35xVQ0vJ+lTbAYnC4lk5/+dSwqX8=; b=ZumWD2gbzDVVh0em0XXKhyeFBCSvzS74Km6EmflWMjAY7kUMFDUbr59t0BNqqEHL4J AiB7ACQ4kX8sCUotiJU5wf8AY8Crv+RmBwGjoerngeT+LzmClMHX51SouRpEHhE8BoU0 lun8zUpuUnzVEMLCGuj1KLxP5IaFL/yxoXlof1f5tiOTgAGj+96rAfGLKqRlYO3G+yMY 8ujdS4Hr+ERCgDLov0MdbTSkybjQwn0TUsUJv/jW32RL9NQZFR7xwJ14tLInmeYQvCnx 4bGMpX3SX/4vmsN9ZRk8LA8g6+1ew+KctZnkhVspekfbhMJ3NR+R2XfqhGAOkJRs6qv+ Tpgw== X-Gm-Message-State: APjAAAWXgCqSToiIk0oqpyDT1xcl7AyIH5Hj9By2mHfqauQjMtecLOrA dapOaBRBlb96fL/CNWhTEShBlg== X-Google-Smtp-Source: APXvYqwvZqoB7HcLldyB5hnboWptllAQCHpm5/Temh8iNOZUGFHOn/N74uzD1wlGnZSad8s+yXbosA== X-Received: by 2002:a1f:8d0b:: with SMTP id p11mr4674585vkd.31.1558703264670; Fri, 24 May 2019 06:07:44 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::e914]) by smtp.gmail.com with ESMTPSA id v14sm815351vkd.4.2019.05.24.06.07.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 06:07:43 -0700 (PDT) Date: Fri, 24 May 2019 09:07:42 -0400 From: Josef Bacik To: Yao Liu Cc: Josef Bacik , Jens Axboe , linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server Message-ID: <20190524130740.zfypc2j3q5e3gryr@MacBook-Pro-91.local.dhcp.thefacebook.com> References: <1558691036-16281-1-git-send-email-yotta.liu@ucloud.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1558691036-16281-1-git-send-email-yotta.liu@ucloud.cn> User-Agent: NeoMutt/20180716 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, May 24, 2019 at 05:43:54PM +0800, Yao Liu wrote: > Some I/O requests that have been sent succussfully but have not yet been > replied won't be resubmitted after reconnecting because of server restart, > so we add a list to track them. > > Signed-off-by: Yao Liu Nack, this is what the timeout stuff is supposed to handle. The commands will timeout and we'll resubmit them if we have alive sockets. Thanks, Josef