Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Fam Zheng <fam@euphon.net>
Subject: Re: [GIT PULL] Block fixes for 5.2-rc4
Date: Mon, 10 Jun 2019 08:48:20 -0700
Message-ID: <20190610154820.GA3341036@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <90A8C242-E45A-4D6E-8797-598893F86393@linaro.org>

Hello, Paolo.

On Mon, Jun 10, 2019 at 04:49:47PM +0200, Paolo Valente wrote:
> 1) General solution allowing multiple entities to share common files:
>    rejected by Tejun.

It was printing outputs from multiple policies for the same device in
the same file without any way of telling which one is actually being
used.  It can't work that way.  We can't show stuff which don't make
sense to users as a part of the kernel interface.  A general solution,
if we want to pursue, would be in this direction but something which
actually considers what's being used where, but an easier alternative
would be selecting the active policy system-wide.

> 2) Simple replacement bfq.weight -> weight, after the only entity
>    using that name, cfq, has gone: rejected by Jens because it is a
>    disruptive change of the interface.
> 3) Symlink, proposed by Johannes: maybe rejected by Tejun.
> Tejun, could you please tell us whether you may accept the last
> option?  This option may be associated with deprecating the explicit
> use of bfq.weight (I don't know of anybody who wants to use this
> confusing name).  So, in a few releases we could finally drop this
> bfq.weight and turn the symlink back into an actual interface file.

Yeah, it'd either have to be 2) or 3) but I wasn't really engaged in
the discussion.  The simplest would be just renaming the interface
file given that that was ppl were using anyway.  Jens, if you aren't
too opposed to it, let's just rename bfq.weight to weight.

Thanks.

-- 
tejun

  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08  8:20 Jens Axboe
2019-06-08 19:28 ` Linus Torvalds
2019-06-09  5:59   ` Jens Axboe
2019-06-09 16:06     ` Linus Torvalds
2019-06-10 10:15       ` Jens Axboe
2019-06-10 14:49         ` Paolo Valente
2019-06-10 15:48           ` Tejun Heo [this message]
2019-06-11 19:49             ` [PATCH block/for-5.2-fixes] bfq: use io.weight interface file instead of io.bfq.weight Tejun Heo
2019-06-11 21:17               ` Tejun Heo
2019-06-12  7:32                 ` Paolo Valente
2019-06-12 13:39                   ` Tejun Heo
2019-06-13  6:10                     ` Paolo Valente
2019-06-14 20:22                       ` Tejun Heo
2019-06-14 21:05                         ` Paolo Valente
2019-06-08 19:30 ` [GIT PULL] Block fixes for 5.2-rc4 pr-tracker-bot

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190610154820.GA3341036@devbig004.ftw2.facebook.com \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=fam@euphon.net \
    --cc=hannes@cmpxchg.org \
    --cc=jthumshirn@suse.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=paolo.valente@linaro.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox