Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: fruggeri@arista.com (Francesco Ruggeri)
To: fruggeri@arista.com, gtertych@cisco.com, gwendal@chromium.org,
	bvanassche@acm.org, linux-block@vger.kernel.org, axboe@kernel.dk,
	stable@vger.kernel.org, jaegeuk@kernel.org
Subject: Re: [PATCH v2] loop: avoid EAGAIN, if offset or block size are changed
Date: Mon, 10 Jun 2019 14:49:54 -0700
Message-ID: <20190610214954.694BA95C1DF4@us180.sjc.aristanetworks.com> (raw)

> This patch tries to avoid EAGAIN due to nrpages!=0 that was originally trying
> to drop stale pages resulting in wrong data access.
> Report: https://bugs.chromium.org/p/chromium/issues/detail?id=938958#c38
> 
> Cc: <stable@vger.kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Cc: Bart Van Assche <bvanassche@acm.org>
> Fixes: 5db470e229e2 ("loop: drop caches if offset or block_size are changed")
> Reported-by: Gwendal Grignou <gwendal@chromium.org>
> Reported-by: grygorii tertychnyi <gtertych@cisco.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> v2 from v1:
>  - remove obsolete jump

FWIW, after applying this patch to 4.19.47, losetup is not failing any
more for me.

Thanks,
Francesco Ruggeri



             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 21:49 fruggeri [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-05-18  0:47 [PATCH] loop: avoid EAGAIN, if offset or block_size " Jaegeuk Kim
2019-05-18  0:53 ` [PATCH v2] " Jaegeuk Kim

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190610214954.694BA95C1DF4@us180.sjc.aristanetworks.com \
    --to=fruggeri@arista.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=gtertych@cisco.com \
    --cc=gwendal@chromium.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox