From: David Sterba <dsterba@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: dsterba@suse.com, clm@fb.com, josef@toxicpanda.com,
axboe@kernel.dk, jack@suse.cz, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 7/8] Btrfs: use REQ_CGROUP_PUNT for worker thread submitted bios
Date: Fri, 14 Jun 2019 17:15:24 +0200 [thread overview]
Message-ID: <20190614151524.GZ3563@twin.jikos.cz> (raw)
In-Reply-To: <20190614003350.1178444-8-tj@kernel.org>
On Thu, Jun 13, 2019 at 05:33:49PM -0700, Tejun Heo wrote:
> @@ -1251,12 +1258,29 @@ static int cow_file_range_async(struct inode *inode, struct page *locked_page,
> * to unlock it.
> */
> if (locked_page) {
> + /*
> + * Depending on the compressibility, the pages
> + * might or might not go through async. We want
> + * all of them to be accounted against @wbc once.
> + * Let's do it here before the paths diverge. wbc
> + * accounting is used only for foreign writeback
> + * detection and doesn't need full accuracy. Just
> + * account the whole thing against the first page.
> + */
> + wbc_account_io(wbc, locked_page, cur_end - start);
> async_chunk[i].locked_page = locked_page;
> locked_page = NULL;
> } else {
> async_chunk[i].locked_page = NULL;
> }
>
> + if (blkcg_css != blkcg_root_css) {
> + css_get(blkcg_css);
fs/btrfs/inode.c: In function ‘cow_file_range_async’:
fs/btrfs/inode.c:1278:4: error: implicit declaration of function ‘css_get’; did you mean ‘css_put’? [-Werror=implicit-function-declaration]
1278 | css_get(blkcg_css);
| ^~~~~~~
| css_put
I don't have CONFIG_CGROUPS enabled in the testing kernel so this probably
needs a wrapper so the ifdef is not in the middle of the function.
next prev parent reply other threads:[~2019-06-14 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 0:33 [PATCHSET btrfs/for-next] btrfs: fix cgroup writeback support Tejun Heo
2019-06-14 0:33 ` [PATCH 1/8] blkcg, writeback: Add wbc->no_wbc_acct Tejun Heo
2019-06-14 13:41 ` Josef Bacik
2019-06-14 0:33 ` [PATCH 2/8] blkcg, writeback: Implement wbc_blkcg_css() Tejun Heo
2019-06-14 13:41 ` Josef Bacik
2019-06-14 0:33 ` [PATCH 3/8] blkcg: implement REQ_CGROUP_PUNT Tejun Heo
2019-06-14 13:43 ` Josef Bacik
2019-06-14 0:33 ` [PATCH 4/8] Btrfs: stop using btrfs_schedule_bio() Tejun Heo
2019-06-14 13:45 ` Josef Bacik
2019-06-14 0:33 ` [PATCH 5/8] Btrfs: delete the entire async bio submission framework Tejun Heo
2019-06-14 13:48 ` Josef Bacik
2019-06-14 0:33 ` [PATCH 6/8] Btrfs: only associate the locked page with one async_cow struct Tejun Heo
2019-06-14 13:48 ` Josef Bacik
2019-06-14 0:33 ` [PATCH 7/8] Btrfs: use REQ_CGROUP_PUNT for worker thread submitted bios Tejun Heo
2019-06-14 13:50 ` Josef Bacik
2019-06-14 15:15 ` David Sterba [this message]
2019-06-14 15:34 ` Tejun Heo
2019-06-14 0:33 ` [PATCH 8/8] Btrfs: extent_write_locked_range() should attach inode->i_wb Tejun Heo
2019-06-14 14:12 ` Josef Bacik
2019-06-14 15:32 ` [PATCH v2 " Tejun Heo
2019-06-14 17:46 ` [PATCHSET btrfs/for-next] btrfs: fix cgroup writeback support Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614151524.GZ3563@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).