From: Ming Lei <ming.lei@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Weiping Zhang <zhangweiping@didiglobal.com>,
axboe@kernel.dk, Tejun Heo <tj@kernel.org>,
Christoph Hellwig <hch@lst.de>,
bvanassche@acm.org, keith.busch@intel.com,
minwoo.im.dev@gmail.com, linux-block@vger.kernel.org,
cgroups@vger.kernel.org, linux-nvme@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] genirq/affinity: allow driver's discontigous affinity set
Date: Tue, 25 Jun 2019 10:14:12 +0800 [thread overview]
Message-ID: <20190625021411.GD23777@ming.t460p> (raw)
In-Reply-To: <alpine.DEB.2.21.1906241740320.32342@nanos.tec.linutronix.de>
Hi Thomas,
On Mon, Jun 24, 2019 at 05:42:39PM +0200, Thomas Gleixner wrote:
> On Mon, 24 Jun 2019, Weiping Zhang wrote:
>
> > The driver may implement multiple affinity set, and some of
> > are empty, for this case we just skip them.
>
> Why? What's the point of creating empty sets? Just because is not a real
> good justification.
Patch 5 will add 4 new sets for supporting NVMe's weighted round robin
arbitration. It can be a headache to manage so many irq sets(now the total
sets can become 6) dynamically since size of anyone in the new 4 sets can
be zero, so each particular set is assigned one static index for avoiding
the management trouble, then empty set will be seen by
irq_create_affinity_masks().
So looks skipping the empty set makes sense because the API will become
easier to use than before.
Thanks,
Ming
next prev parent reply other threads:[~2019-06-25 2:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1561385989.git.zhangweiping@didiglobal.com>
2019-06-24 14:28 ` [PATCH v3 1/5] block: add weighted round robin for blkcgroup Weiping Zhang
2019-07-18 13:59 ` Tejun Heo
2019-07-23 14:29 ` Weiping Zhang
2019-06-24 14:29 ` [PATCH v3 2/5] nvme: add get_ams for nvme_ctrl_ops Weiping Zhang
2019-06-24 20:12 ` Minwoo Im
2019-06-25 14:46 ` Weiping Zhang
2019-06-24 14:29 ` [PATCH v3 3/5] nvme-pci: rename module parameter write_queues to read_queues Weiping Zhang
2019-06-24 20:04 ` Minwoo Im
2019-06-25 14:48 ` Weiping Zhang
2019-06-26 20:27 ` Minwoo Im
2019-06-24 14:29 ` [PATCH v3 4/5] genirq/affinity: allow driver's discontigous affinity set Weiping Zhang
2019-06-24 15:42 ` Thomas Gleixner
2019-06-25 2:14 ` Ming Lei [this message]
2019-06-25 6:13 ` Thomas Gleixner
2019-06-25 14:55 ` Weiping Zhang
2019-06-24 14:29 ` [PATCH v3 5/5] nvme: add support weighted round robin queue Weiping Zhang
2019-06-24 20:21 ` Minwoo Im
2019-06-25 15:06 ` Weiping Zhang
2019-06-27 10:37 ` Minwoo Im
2019-06-27 11:03 ` Christoph Hellwig
2019-06-28 15:57 ` Weiping Zhang
2019-07-10 14:20 ` Weiping Zhang
2019-07-29 10:22 ` Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625021411.GD23777@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).