From: Scott Bauer <sbauer@plzdonthack.me>
To: axboe@kernel.dk
Cc: jonathan.derrick@intel.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zub@linux.fjfi.cvut.cz" <zub@linux.fjfi.cvut.cz>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jonas.rabenstein@studium.uni-erlangen.de"
<jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write
Date: Sat, 29 Jun 2019 12:19:55 -0400 [thread overview]
Message-ID: <20190629161947.GA20127@hacktheplanet> (raw)
In-Reply-To: <7ee5d705c12d770bf7566bce7d664bf733b25206.camel@intel.com>
Hey Jens,
Can you please stage these for 5.3 aswell?
On Tue, Jun 25, 2019 at 08:47:26PM +0000, Derrick, Jonathan wrote:
> These are still good with me and we'll likely have a similar future use
> for passing data through the ioctl.
>
> Could we get this staged for 5.3?
>
> On Tue, 2019-05-21 at 22:46 +0200, David Kozub wrote:
> > This patch series extends SED Opal support: it adds IOCTL for setting the shadow
> > MBR done flag which can be useful for unlocking an Opal disk on boot and it adds
> > IOCTL for writing to the shadow MBR.
> >
> > This applies on current master.
> >
> > I successfully tested toggling the MBR done flag and writing the shadow MBR
> > using some tools I hacked together[1] with a Samsung SSD 850 EVO drive.
> >
> > Changes from v1:
> > * PATCH 2/3: remove check with access_ok, just rely on copy_from_user as
> > suggested in [2] (I tested passing data == 0 and I got the expected EFAULT)
> >
> > [1] https://gitlab.com/zub2/opalctl
> > [2] https://lore.kernel.org/lkml/20190501134833.GB24132@infradead.org/
> >
> > Jonas Rabenstein (3):
> > block: sed-opal: add ioctl for done-mark of shadow mbr
> > block: sed-opal: ioctl for writing to shadow mbr
> > block: sed-opal: check size of shadow mbr
> >
> > block/opal_proto.h | 16 ++++
> > block/sed-opal.c | 157 +++++++++++++++++++++++++++++++++-
> > include/linux/sed-opal.h | 2 +
> > include/uapi/linux/sed-opal.h | 20 +++++
> > 4 files changed, 193 insertions(+), 2 deletions(-)
> >
next prev parent reply other threads:[~2019-06-29 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 20:46 [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write David Kozub
2019-05-21 20:46 ` [PATCH v2 1/3] block: sed-opal: add ioctl for done-mark of shadow mbr David Kozub
2019-05-21 20:46 ` [PATCH v2 2/3] block: sed-opal: ioctl for writing to " David Kozub
2019-05-21 20:46 ` [PATCH v2 3/3] block: sed-opal: check size of " David Kozub
2019-06-25 20:47 ` [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write Derrick, Jonathan
2019-06-29 16:19 ` Scott Bauer [this message]
2019-06-29 16:26 ` Jens Axboe
2019-06-29 16:28 ` Scott Bauer
2019-06-29 16:35 ` Jens Axboe
2019-06-29 16:37 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629161947.GA20127@hacktheplanet \
--to=sbauer@plzdonthack.me \
--cc=axboe@kernel.dk \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zub@linux.fjfi.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).