From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5B7C4321A for ; Sat, 29 Jun 2019 16:37:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AD4820665 for ; Sat, 29 Jun 2019 16:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726856AbfF2Qho (ORCPT ); Sat, 29 Jun 2019 12:37:44 -0400 Received: from bout01.mta.xmission.com ([166.70.11.15]:49749 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfF2Qho (ORCPT ); Sat, 29 Jun 2019 12:37:44 -0400 Received: from mx02.mta.xmission.com ([166.70.13.212]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1hhGM8-0008Vd-Kr; Sat, 29 Jun 2019 10:37:40 -0600 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hhGM7-0000gT-Tq; Sat, 29 Jun 2019 10:37:40 -0600 Received: from hacktheplanet (c-68-50-34-150.hsd1.in.comcast.net [68.50.34.150]) by plesk14.xmission.com (Postfix) with ESMTPSA id 2E121193879; Sat, 29 Jun 2019 16:37:39 +0000 (UTC) Date: Sat, 29 Jun 2019 12:37:37 -0400 From: Scott Bauer To: Jens Axboe Cc: jonathan.derrick@intel.com, "linux-kernel@vger.kernel.org" , "zub@linux.fjfi.cvut.cz" , "linux-block@vger.kernel.org" , "jonas.rabenstein@studium.uni-erlangen.de" Message-ID: <20190629163737.GB21042@hacktheplanet> References: <1558471606-25139-1-git-send-email-zub@linux.fjfi.cvut.cz> <7ee5d705c12d770bf7566bce7d664bf733b25206.camel@intel.com> <20190629161947.GA20127@hacktheplanet> <20190629162835.GA21042@hacktheplanet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1hhGM7-0000gT-Tq;;;mid=<20190629163737.GB21042@hacktheplanet>;;;hst=mx02.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me Subject: Re: [PATCH v2 0/3] block: sed-opal: add support for shadow MBR done flag and write X-SA-Exim-Version: 4.2.1 (built Mon, 03 Jun 2019 09:49:16 -0600) X-SA-Exim-Scanned: Yes (on mx02.mta.xmission.com) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org e1;5202;0csOn Sat, Jun 29, 2019 at 10:35:30AM -0600, Jens Axboe wrote: > On 6/29/19 10:28 AM, Scott Bauer wrote: > > On Sat, Jun 29, 2019 at 10:26:52AM -0600, Jens Axboe wrote: > >> On 6/29/19 10:19 AM, Scott Bauer wrote: > >>> > >>> Hey Jens, > >>> > >>> Can you please stage these for 5.3 aswell? > >> > >> Yes, looks fine to me. But it conflicts with the psid revert in terms > >> of ioctl numbering. You fine with me renumbering IOC_OPAL_MBR_DONE to: > >> > >> #define IOC_OPAL_MBR_DONE _IOW('p', 233, struct opal_mbr_done) > > > > Sorry for the conflict. That's fine. I'll fix up userland tooling. > > Renamed 232 -> 233, and 233 -> 234, for the two conflicts. So now we have: > > #define IOC_OPAL_PSID_REVERT_TPR _IOW('p', 232, struct opal_key) > #define IOC_OPAL_MBR_DONE _IOW('p', 233, struct opal_mbr_done) > #define IOC_OPAL_WRITE_SHADOW_MBR _IOW('p', 234, struct opal_shadow_mbr) Looks good, thank you for handling this.