From: Logan Gunthorpe <logang@deltatee.com>
To: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Omar Sandoval <osandov@fb.com>
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Michael Moese <mmoese@suse.de>, Theodore Ts'o <tytso@mit.edu>,
Johannes Thumshirn <jthumshirn@suse.de>,
Stephen Bates <sbates@raithlin.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH blktests 09/12] nvme: Cleanup modprobe lines into helper functions
Date: Fri, 12 Jul 2019 17:57:39 -0600 [thread overview]
Message-ID: <20190712235742.22646-10-logang@deltatee.com> (raw)
In-Reply-To: <20190712235742.22646-1-logang@deltatee.com>
Move all the lines to modprobe nvmet and nvme-loop
into _setup_nvmet() and _cleanup_nvmet() helper functions
and call _cleanup_nvmet() using _register_test_cleanup()
to ensure it's always called after the test terminates.
This will allow us to improve the cleanup of these tests and
not leave the system in an inconsistent state when tests
are aborted.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
tests/nvme/002 | 8 ++------
tests/nvme/003 | 5 +----
tests/nvme/004 | 5 +----
tests/nvme/005 | 6 +-----
tests/nvme/006 | 6 +-----
tests/nvme/007 | 6 +-----
tests/nvme/008 | 6 +-----
tests/nvme/009 | 5 +----
tests/nvme/010 | 6 +-----
tests/nvme/011 | 6 +-----
tests/nvme/012 | 6 +-----
tests/nvme/013 | 6 +-----
tests/nvme/014 | 6 +-----
tests/nvme/015 | 3 +--
tests/nvme/016 | 4 +---
tests/nvme/017 | 6 +-----
tests/nvme/018 | 3 +--
tests/nvme/019 | 6 +-----
tests/nvme/020 | 5 +----
tests/nvme/021 | 6 +-----
tests/nvme/022 | 6 +-----
tests/nvme/023 | 6 +-----
tests/nvme/024 | 6 +-----
tests/nvme/025 | 6 +-----
tests/nvme/026 | 6 +-----
tests/nvme/027 | 6 +-----
tests/nvme/028 | 6 +-----
tests/nvme/029 | 6 +-----
tests/nvme/030 | 6 +-----
tests/nvme/rc | 11 +++++++++++
30 files changed, 41 insertions(+), 134 deletions(-)
diff --git a/tests/nvme/002 b/tests/nvme/002
index ceac1c677bd4..07b7fdae2d39 100755
--- a/tests/nvme/002
+++ b/tests/nvme/002
@@ -16,11 +16,9 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- local iterations=1000
-
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
+ local iterations=1000
local port
port="$(_create_nvmet_port "loop")"
@@ -41,7 +39,5 @@ test() {
_remove_nvmet_port "${port}"
- modprobe -r nvme-loop
- modprobe -r nvmet
echo "Test complete"
}
diff --git a/tests/nvme/003 b/tests/nvme/003
index 374e6af0ca6f..ed0feca3cac7 100755
--- a/tests/nvme/003
+++ b/tests/nvme/003
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
port="$(_create_nvmet_port "loop")"
@@ -47,7 +46,5 @@ test() {
_remove_nvmet_subsystem "blktests-subsystem-1"
_remove_nvmet_port "${port}"
- modprobe -r nvme-loop
- modprobe -r nvmet
echo "Test complete"
}
diff --git a/tests/nvme/004 b/tests/nvme/004
index 767aedaa0263..0debcd9c7049 100755
--- a/tests/nvme/004
+++ b/tests/nvme/004
@@ -18,8 +18,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
port="$(_create_nvmet_port "loop")"
@@ -47,7 +46,5 @@ test() {
losetup -d "$loop_dev"
rm "$TMPDIR/img"
- modprobe -r nvme-loop
- modprobe -r nvmet
echo "Test complete"
}
diff --git a/tests/nvme/005 b/tests/nvme/005
index 91c164de73e6..8c79d234bb1d 100755
--- a/tests/nvme/005
+++ b/tests/nvme/005
@@ -19,8 +19,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
port="$(_create_nvmet_port "loop")"
@@ -51,8 +50,5 @@ test() {
losetup -d "$loop_dev"
rm "$TMPDIR/img"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/006 b/tests/nvme/006
index d12d66bc5a8d..6c8e18560264 100755
--- a/tests/nvme/006
+++ b/tests/nvme/006
@@ -21,8 +21,7 @@ test() {
local loop_dev
local subsys_name="blktests-subsystem-1"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
truncate -s 1G "$TMPDIR/img"
@@ -41,8 +40,5 @@ test() {
rm "$TMPDIR/img"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/007 b/tests/nvme/007
index 6a57b7bf7e0d..58f4bf8808a1 100755
--- a/tests/nvme/007
+++ b/tests/nvme/007
@@ -20,8 +20,7 @@ test() {
local file_path
local subsys_name="blktests-subsystem-1"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
file_path="${TMPDIR}/img"
@@ -38,8 +37,5 @@ test() {
rm "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/008 b/tests/nvme/008
index 04ff0bda42e3..71ff4d962b00 100755
--- a/tests/nvme/008
+++ b/tests/nvme/008
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -53,8 +52,5 @@ test() {
rm "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/009 b/tests/nvme/009
index 81e61f99aba5..25c7da2ab854 100755
--- a/tests/nvme/009
+++ b/tests/nvme/009
@@ -16,8 +16,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -47,7 +46,5 @@ test() {
rm "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
echo "Test complete"
}
diff --git a/tests/nvme/010 b/tests/nvme/010
index ed7c95af2853..2ed0f4871a30 100755
--- a/tests/nvme/010
+++ b/tests/nvme/010
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -54,8 +53,5 @@ test() {
rm "${file_path}"
rm -f local*verify*state
- modprobe -r nvme_loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/011 b/tests/nvme/011
index fa638a193bad..974b33745b99 100755
--- a/tests/nvme/011
+++ b/tests/nvme/011
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -50,8 +49,5 @@ test() {
rm "${file_path}"
rm -f local-write-and-verify*state
- modprobe -r nvme_loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/012 b/tests/nvme/012
index d7a8751ec752..27981e903c58 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -66,8 +65,5 @@ test() {
rm "${file_path}"
rm -fr "${mount_dir}"
- modprobe -r nvme_loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/013 b/tests/nvme/013
index 131855298f0f..af5f3730a2fc 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -62,8 +61,5 @@ test() {
rm "${file_path}"
rm -fr "${mount_dir}"
- modprobe -r nvme_loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/014 b/tests/nvme/014
index 7de568faeff2..c255d5f12205 100755
--- a/tests/nvme/014
+++ b/tests/nvme/014
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -55,8 +54,5 @@ test() {
rm "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/015 b/tests/nvme/015
index ca1216163e16..a8497a2ba400 100755
--- a/tests/nvme/015
+++ b/tests/nvme/015
@@ -16,8 +16,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
diff --git a/tests/nvme/016 b/tests/nvme/016
index dd1b84a16daa..9e670e7f6bcd 100755
--- a/tests/nvme/016
+++ b/tests/nvme/016
@@ -20,8 +20,7 @@ test() {
local loop_dev
local subsys_nqn="blktests-subsystem-1"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
loop_dev="$(losetup -f)"
@@ -44,6 +43,5 @@ test() {
_remove_nvmet_subsystem "${subsys_nqn}"
- modprobe -r nvme-loop nvmet
echo "Test complete"
}
diff --git a/tests/nvme/017 b/tests/nvme/017
index 5f8d60907293..ef27de65cf2e 100755
--- a/tests/nvme/017
+++ b/tests/nvme/017
@@ -20,8 +20,7 @@ test() {
local iterations=1000
local subsys_name="blktests-subsystem-1"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
file_path="${TMPDIR}/img"
@@ -49,8 +48,5 @@ test() {
rm "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/018 b/tests/nvme/018
index 7b5ade5d3c40..c1231c3de172 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -18,8 +18,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
diff --git a/tests/nvme/019 b/tests/nvme/019
index 4a167361c42c..a8b0204ec0eb 100755
--- a/tests/nvme/019
+++ b/tests/nvme/019
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -55,8 +54,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/020 b/tests/nvme/020
index 6bd8075b1f4d..b480ee1b92d0 100755
--- a/tests/nvme/020
+++ b/tests/nvme/020
@@ -16,8 +16,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -49,7 +48,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
echo "Test complete"
}
diff --git a/tests/nvme/021 b/tests/nvme/021
index fef31b080c99..bbee54d16ff1 100755
--- a/tests/nvme/021
+++ b/tests/nvme/021
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -50,8 +49,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/022 b/tests/nvme/022
index 8f7492c0ff15..9ba07c1cc50f 100755
--- a/tests/nvme/022
+++ b/tests/nvme/022
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -50,8 +49,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/023 b/tests/nvme/023
index de1a6bc0f975..ed2a5ad7653f 100755
--- a/tests/nvme/023
+++ b/tests/nvme/023
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -55,8 +54,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/024 b/tests/nvme/024
index c88fbd8a3663..538580947c5c 100755
--- a/tests/nvme/024
+++ b/tests/nvme/024
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -49,8 +48,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/025 b/tests/nvme/025
index 6468f59d9dd9..0039fefa5007 100755
--- a/tests/nvme/025
+++ b/tests/nvme/025
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -50,8 +49,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/026 b/tests/nvme/026
index 2e9655bdd40f..7e89d840529c 100755
--- a/tests/nvme/026
+++ b/tests/nvme/026
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -50,8 +49,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/027 b/tests/nvme/027
index db732425db21..4d293beb8b47 100755
--- a/tests/nvme/027
+++ b/tests/nvme/027
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -49,8 +48,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/028 b/tests/nvme/028
index 10be8fb4ba9c..1280107ed5df 100755
--- a/tests/nvme/028
+++ b/tests/nvme/028
@@ -17,8 +17,7 @@ requires() {
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -49,8 +48,5 @@ test() {
rm -f "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/029 b/tests/nvme/029
index e63dfc166f26..65eb40031888 100755
--- a/tests/nvme/029
+++ b/tests/nvme/029
@@ -50,8 +50,7 @@ test_user_io()
test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
local port
local nvmedev
@@ -92,8 +91,5 @@ test() {
rm "${file_path}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/030 b/tests/nvme/030
index 963e1ad7118c..94020f47411e 100755
--- a/tests/nvme/030
+++ b/tests/nvme/030
@@ -36,8 +36,7 @@ test() {
echo "Running ${TEST_NAME}"
- modprobe nvmet
- modprobe nvme-loop
+ _setup_nvmet
port="$(_create_nvmet_port "loop")"
@@ -69,8 +68,5 @@ test() {
_remove_nvmet_port "${port}"
- modprobe -r nvme-loop
- modprobe -r nvmet
-
echo "Test complete"
}
diff --git a/tests/nvme/rc b/tests/nvme/rc
index 39b2c2e2b91c..b8f7571c7170 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -24,6 +24,17 @@ _test_dev_is_nvme() {
return 0
}
+_cleanup_nvmet() {
+ modprobe -r nvme-loop
+ modprobe -r nvmet
+}
+
+_setup_nvmet() {
+ _register_test_cleanup _cleanup_nvmet
+ modprobe nvmet
+ modprobe nvme-loop
+}
+
_create_nvmet_port() {
local trtype="$1"
--
2.17.1
next prev parent reply other threads:[~2019-07-12 23:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 23:57 [PATCH blktests 00/12] Fix nvme block test issues Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 01/12] Add filter function for nvme discover Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 03/12] nvme: Add new test to verify the generation counter Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 04/12] nvme/003,004: Add missing calls to nvme disconnect Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 05/12] nvme/005: Don't rely on modprobing to set the multipath paramater Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 06/12] nvme/015: Ensure the namespace is flushed not the char device Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 07/12] nvme/018: Ignore error message generated by nvme read Logan Gunthorpe
2019-07-15 7:15 ` [PATCH blktests 07/12] nvme/018: Ignore error message generated by nvme read] Johannes Thumshirn
2019-07-15 15:40 ` Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 08/12] check: Add the ability to call a cleanup function after a test ends Logan Gunthorpe
2019-07-12 23:57 ` Logan Gunthorpe [this message]
2019-07-12 23:57 ` [PATCH blktests 10/12] nvme: Ensure all ports and subsystems are removed on cleanup Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 11/12] common: Use sysfs instead of modinfo for _have_module_param() Logan Gunthorpe
2019-07-15 7:21 ` Johannes Thumshirn
2019-07-15 15:41 ` Logan Gunthorpe
2019-07-12 23:57 ` [PATCH blktests 12/12] nvme: Ignore errors when removing modules Logan Gunthorpe
2019-07-13 0:01 ` [PATCH blktests 00/12] Fix nvme block test issues Logan Gunthorpe
2019-07-15 17:14 ` Chaitanya Kulkarni
[not found] ` <20190712235742.22646-3-logang@deltatee.com>
2019-07-15 23:07 ` [PATCH blktests 02/12] nvme: More agressively filter the discovery output Omar Sandoval
2019-07-15 23:14 ` [PATCH blktests 00/12] Fix nvme block test issues Omar Sandoval
2019-07-15 23:16 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712235742.22646-10-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mmoese@suse.de \
--cc=osandov@fb.com \
--cc=sbates@raithlin.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).