From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34465C76194 for ; Thu, 25 Jul 2019 17:40:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0742D22BEF for ; Thu, 25 Jul 2019 17:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564076440; bh=v5yXlm0ySbjH9KYVN6Nqcko2ymh4rZfsF2TdFPmyY7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j7/JBXJFZ4vJ58Et5q78vc2x+KhcrZOfF9bzpxu6eJ6Ox7dcBFPfSd5x/dUZ1a33L tHOuUqU0Fck71aY6rjzvlQnhVvYFitawzo763uWRZCFXjflpyYMtY98FomCelz39Zu l/v6BPsNoega+SgjT/Ppec7su+E41o19W8XlRigQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727094AbfGYRkg (ORCPT ); Thu, 25 Jul 2019 13:40:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfGYRkg (ORCPT ); Thu, 25 Jul 2019 13:40:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79AF422BE8; Thu, 25 Jul 2019 17:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564076435; bh=v5yXlm0ySbjH9KYVN6Nqcko2ymh4rZfsF2TdFPmyY7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cf0NrbzxwN1M9j7L43mP+u3u8SJKAyjDsM0cOYEdgJvIpWskctistAzocLZjDHkEN ba/45n2CQ0Z0Vu5YE8bZ1WQSq7k3lFsVvFslO0EgJItOxPoN3cpbF0XLhnLZMiHACv SqahQYWRTwQbD+2RwOPjk7Yu0qf8B7tBjUz8+4cA= Date: Thu, 25 Jul 2019 19:40:32 +0200 From: Greg Kroah-Hartman To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , Jens Axboe , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates , Alexander Viro Subject: Re: [PATCH v6 02/16] chardev: introduce cdev_get_by_path() Message-ID: <20190725174032.GA27818@kroah.com> References: <20190725172335.6825-1-logang@deltatee.com> <20190725172335.6825-3-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725172335.6825-3-logang@deltatee.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jul 25, 2019 at 11:23:21AM -0600, Logan Gunthorpe wrote: > cdev_get_by_path() attempts to retrieve a struct cdev from > a path name. It is analagous to blkdev_get_by_path(). > > This will be necessary to create a nvme_ctrl_get_by_path()to > support NVMe-OF passthru. Ick, why? Why would a cdev have a "pathname"? What is "NVMe-OF passthru"? Why does a char device node have anything to do with NVMe? We have way too many ways to abuse cdevs today, my long-term-wish has always been to clean this interface up to make it more sane and unified, and get rid of the "outliers" (all created at the time for a good reason, that's not the problem.) But to add "just one more" seems really odd to me. thanks, greg k-h