From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C273AC76190 for ; Thu, 25 Jul 2019 19:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 926F1206DD for ; Thu, 25 Jul 2019 19:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="l8FB5LIM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbfGYTA0 (ORCPT ); Thu, 25 Jul 2019 15:00:26 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56428 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfGYTAZ (ORCPT ); Thu, 25 Jul 2019 15:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=T12SANXJfFYGAgoypYepvPduiF69NIPuQswfYpT9irw=; b=l8FB5LIMV6v7FUzlsTxEQEgEt sYro009Akgm0ixWwNSlGthAnEQgNl1iQFyHCu1a3RgQlxVxqBANR1p9gZ2y7GEywWQ9aDahvzUiVP Zs7V6DPQm1qPQIzYhov0+BhUQ52M02dK3QuPm3HzGlFZU3Y7xR7qV8f3xR7QqSiwVikvwTV6pI6Am mWOOyyRp0q8dTEpuomnAvNgjREwacnPoB/C/PNOBkQ3nbEEVz2inA+QEhT/cZrAE9D0dqwpksdM+n SFhQ2eKPAajA9RgBLos3BC0H7I/y2iOFuCevwBD3y5NogKUmK1M8VGzAQMg2nGEWO0vdbiA92btPP 9FihCjsVg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hqiyW-0001Cp-7l; Thu, 25 Jul 2019 19:00:24 +0000 Date: Thu, 25 Jul 2019 12:00:24 -0700 From: Matthew Wilcox To: Greg Kroah-Hartman Cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , Jens Axboe , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates , Alexander Viro Subject: Re: [PATCH v6 02/16] chardev: introduce cdev_get_by_path() Message-ID: <20190725190024.GD30641@bombadil.infradead.org> References: <20190725172335.6825-1-logang@deltatee.com> <20190725172335.6825-3-logang@deltatee.com> <20190725174032.GA27818@kroah.com> <682ff89f-04e0-7a94-5aeb-895ac65ee7c9@deltatee.com> <20190725180816.GA32305@kroah.com> <20190725182701.GA11547@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725182701.GA11547@kroah.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jul 25, 2019 at 08:27:01PM +0200, Greg Kroah-Hartman wrote: > > NVMe-OF is configured using configfs. The target is specified by the > > user writing a path to a configfs attribute. This is the way it works > > today but with blkdev_get_by_path()[1]. For the passthru code, we need > > to get a nvme_ctrl instead of a block_device, but the principal is the same. > > Why isn't a fd being passed in there instead of a random string? I suppose we could echo a string of the file descriptor number there, and look up the fd in the process' file descriptor table ... I'll get my coat.