archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <>
To: Jens Axboe <>
Cc:, Christoph Hellwig <>,
	Bart Van Assche <>
Subject: [PATCH v2 0/2] Fix a race condition triggered by submit_bio()
Date: Tue, 30 Jul 2019 11:36:51 -0700	[thread overview]
Message-ID: <> (raw)

Hi Jens,

One of the consequences of the switch to blk-mq is that generic_make_request()
calls, a function called by submit_bio(), must be protected by a
blk_queue_enter() / blk_queue_exit() pair to avoid that the block-cgroup
functions called by generic_make_request() trigger a race condition. This patch
series makes the kernel report a warning if that race condition is hit and also
adds the necessary protection in submit_bio(). Please consider these patches
for kernel v5.4.



Changes compared to v1:
- Use the full syzbot ID in patch 2/2 instead of abbreviating it.

Bart Van Assche (2):
  block: Verify whether blk_queue_enter() is used when necessary
  block: Fix a race condition in submit_bio()

 block/blk-cgroup.c         |  2 ++
 block/blk-core.c           | 34 +++++++++++++++++++++++++++++++++-
 include/linux/blk-cgroup.h |  2 ++
 include/linux/blkdev.h     |  8 ++++++++
 4 files changed, 45 insertions(+), 1 deletion(-)


             reply	other threads:[~2019-07-30 18:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 18:36 Bart Van Assche [this message]
2019-07-30 18:36 ` [PATCH v2 1/2] block: Verify whether blk_queue_enter() is used when necessary Bart Van Assche
2019-07-30 18:36 ` [PATCH v2 2/2] block: Fix a race condition in submit_bio() Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).