From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Jeff Moyer <jmoyer@redhat.com>,
Aarushi Mehta <mehta.aaru20@gmail.com>,
linux-block@vger.kernel.org, Julia Suvorova <jusual@mail.ru>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH liburing 4/4] spec: fix <liburing/*.h> permissions
Date: Sat, 3 Aug 2019 09:45:26 +0100 [thread overview]
Message-ID: <20190803084526.3837-5-stefanha@redhat.com> (raw)
In-Reply-To: <20190803084526.3837-1-stefanha@redhat.com>
There are two issues with the <liburing/*.h> headers:
1. They are installed with 0755 permissions.
2. The empty /usr/include/liburing/ directory is left behind by rpm -e.
Fix this by specifying the directory (not just globbing the files inside
it) and letting rpm use the default permissions on these files.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
liburing.spec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/liburing.spec b/liburing.spec
index 31dfde0..1337034 100644
--- a/liburing.spec
+++ b/liburing.spec
@@ -48,7 +48,7 @@ make install DESTDIR=$RPM_BUILD_ROOT
%files devel
%defattr(-,root,root)
-%attr(0755,root,root) %{_includedir}/liburing/*
+%attr(-,root,root) %{_includedir}/liburing/
%attr(0644,root,root) %{_includedir}/liburing.h
%attr(0755,root,root) %{_libdir}/liburing.so
%attr(0644,root,root) %{_libdir}/liburing.a
--
2.21.0
next prev parent reply other threads:[~2019-08-03 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 8:45 [PATCH liburing 0/4] spec: rpmlint fixes in preparation for Fedora packaging Stefan Hajnoczi
2019-08-03 8:45 ` [PATCH liburing 1/4] COPYING: update to latest LGPL v2.1 text Stefan Hajnoczi
2019-08-03 8:45 ` [PATCH liburing 2/4] spec: use Fedora "LGPLv2+" license identifier Stefan Hajnoczi
2019-08-03 8:45 ` [PATCH liburing 3/4] spec: add URL tag Stefan Hajnoczi
2019-08-03 8:45 ` Stefan Hajnoczi [this message]
2019-08-03 14:25 ` [PATCH liburing 0/4] spec: rpmlint fixes in preparation for Fedora packaging Jens Axboe
[not found] ` <20190805161411.GA10487@stefanha-x1.localdomain>
[not found] ` <20190808103254.GA3120@stefanha-x1.localdomain>
2019-08-08 16:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190803084526.3837-5-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=jusual@mail.ru \
--cc=linux-block@vger.kernel.org \
--cc=mehta.aaru20@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).