From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, jack@suse.cz, hannes@cmpxchg.org,
mhocko@kernel.org, vdavydov.dev@gmail.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, guro@fb.com
Subject: Re: [PATCH 2/4] bdi: Add bdi->id
Date: Tue, 6 Aug 2019 16:01:02 -0700 [thread overview]
Message-ID: <20190806160102.11366694af6b56d9c4ca6ea3@linux-foundation.org> (raw)
In-Reply-To: <20190803140155.181190-3-tj@kernel.org>
On Sat, 3 Aug 2019 07:01:53 -0700 Tejun Heo <tj@kernel.org> wrote:
> There currently is no way to universally identify and lookup a bdi
> without holding a reference and pointer to it. This patch adds an
> non-recycling bdi->id and implements bdi_get_by_id() which looks up
> bdis by their ids. This will be used by memcg foreign inode flushing.
Why is the id non-recycling? Presumably to address some
lifetime/lookup issues, but what are they?
Why was the IDR code not used?
> I left bdi_list alone for simplicity and because while rb_tree does
> support rcu assignment it doesn't seem to guarantee lossless walk when
> walk is racing aginst tree rebalance operations.
>
> ...
>
> +/**
> + * bdi_get_by_id - lookup and get bdi from its id
> + * @id: bdi id to lookup
> + *
> + * Find bdi matching @id and get it. Returns NULL if the matching bdi
> + * doesn't exist or is already unregistered.
> + */
> +struct backing_dev_info *bdi_get_by_id(u64 id)
> +{
> + struct backing_dev_info *bdi = NULL;
> + struct rb_node **p;
> +
> + spin_lock_irq(&bdi_lock);
Why irq-safe? Everywhere else uses spin_lock_bh(&bdi_lock).
> + p = bdi_lookup_rb_node(id, NULL);
> + if (*p) {
> + bdi = rb_entry(*p, struct backing_dev_info, rb_node);
> + bdi_get(bdi);
> + }
> + spin_unlock_irq(&bdi_lock);
> +
> + return bdi;
> +}
> +
>
> ...
>
next prev parent reply other threads:[~2019-08-06 23:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 14:01 [PATCHSET] writeback, memcg: Implement foreign inode flushing Tejun Heo
2019-08-03 14:01 ` [PATCH 1/4] writeback: Generalize and expose wb_completion Tejun Heo
2019-08-15 14:41 ` Jan Kara
2019-08-03 14:01 ` [PATCH 2/4] bdi: Add bdi->id Tejun Heo
2019-08-03 15:39 ` Matthew Wilcox
2019-08-03 15:53 ` Tejun Heo
2019-08-03 16:17 ` Matthew Wilcox
2019-08-06 23:01 ` Andrew Morton [this message]
2019-08-07 18:31 ` Tejun Heo
2019-08-07 19:00 ` Andrew Morton
2019-08-07 20:34 ` Tejun Heo
2019-08-09 0:57 ` Rik van Riel
2019-08-15 14:46 ` Jan Kara
2019-08-15 17:34 ` Tejun Heo
2019-08-03 14:01 ` [PATCH 3/4] writeback, memcg: Implement cgroup_writeback_by_id() Tejun Heo
2019-08-15 14:05 ` Jan Kara
2019-08-15 15:43 ` Tejun Heo
2019-08-15 14:54 ` Jan Kara
2019-08-15 16:12 ` Tejun Heo
2019-08-03 14:01 ` [PATCH 4/4] writeback, memcg: Implement foreign dirty flushing Tejun Heo
2019-08-06 23:03 ` Andrew Morton
2019-08-07 18:34 ` Tejun Heo
2019-08-15 14:34 ` Jan Kara
2019-08-15 17:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806160102.11366694af6b56d9c4ca6ea3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).