From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBAC2C433FF for ; Tue, 6 Aug 2019 23:57:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA1D420663 for ; Tue, 6 Aug 2019 23:57:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="W8eEgM2i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726331AbfHFX5R (ORCPT ); Tue, 6 Aug 2019 19:57:17 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36052 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbfHFX5M (ORCPT ); Tue, 6 Aug 2019 19:57:12 -0400 Received: by mail-wm1-f65.google.com with SMTP id g67so74018789wme.1 for ; Tue, 06 Aug 2019 16:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jfBO9hCNqYo64ONFM6ciZWbt58m9OYqaTu2HQ9ca9Ro=; b=W8eEgM2it0wryCQemd+9sTsxohxFSftJHniJZ5Qr1hletzTU3TNMP1w2zUH/hfEuyL 0au0nFicRsBByjUVgItZ0FtKdIpaCavvW1sRv2pm8h3YDr6nL2e8gnVavWNGVQpWip/T 5mI7nVfekdb19B4eyRMnImDBHWb0FMcuYpX5A97FOG6afLhCWQb+V7KsuMdmM8CJgMTj gY58iFdklW31tLr8gjYOP6HV4zZtOWxNsDsPPtFNu0t4Qs97YGVrncp3eRuqu5RfuI2l LELLaXTY4KdsSWOpYJSSqfhMOT0S3g+8iQK0nNIljP4ioEqsDzwKUjIFNI4cl1v+ZBzQ eBjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jfBO9hCNqYo64ONFM6ciZWbt58m9OYqaTu2HQ9ca9Ro=; b=o8Smn/f5kUc4UQ4I1OpMb5Gd43zxp+OvF8WKw1Oo9uRbgTxxvskLyUk1MbZPn9ZiMw /3m28KwHEdPPS+wHsELi97jH1nmRh172C8IKihN6jCDJbdZGP9YFB8z5/h1uWsalPp1j YchvqQ6/+3u2Rk0V5My+fPJW/iDSVGIHgVx1YyN0TFZ2yH6kOMWDwUqHF/x4SrAmg9eC IoMHS21LNnf2jKPDh3gO/ZIHR4rxEe1QaOA76qQIArgGVGXqDPS0nEcbJwSxDSUMJFYb onge7/xX6Hb4ledUABh5+gviyqE5P4Sxqw+Iu8809nHw1GsG+u9yT0LR4xb2YtM/3o8g y7DQ== X-Gm-Message-State: APjAAAVlDmZcZRviNX3N14EruURzSTL6ZqNQ1UOz0NG/GnrSdvGXX2nm V34YpBxcHXGSDIm+S3SkeUj1nQ== X-Google-Smtp-Source: APXvYqwvAhL5NTzknYTD6D/k6t0NbWDbuFz6QsImjCl9poL59Fzt5ijxAEO79VvVV+dV8ZfyhIK5nA== X-Received: by 2002:a1c:4b0b:: with SMTP id y11mr7085231wma.25.1565135830388; Tue, 06 Aug 2019 16:57:10 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e751:37a0:1e95:e65d]) by smtp.gmail.com with ESMTPSA id b19sm63982440wmj.13.2019.08.06.16.57.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 16:57:09 -0700 (PDT) Date: Wed, 7 Aug 2019 00:57:08 +0100 From: Alessio Balsini To: Joel Fernandes Cc: "open list:BLOCK LAYER" , LKML , Jens Axboe , dvander@gmail.com, Yifan Hong , Greg Kroah-Hartman , "Cc: Android Kernel" Subject: Re: [PATCH] loop: Add LOOP_SET_DIRECT_IO in compat ioctl Message-ID: <20190806235708.GA10161@google.com> References: <20190806220524.251404-1-balsini@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Joel, I was considering the rationale for this patch totally strightforward: it enables Direct I/O ioctl to 32 bit processes running on 64 bit systems for compatibility reasons, as for all the other lo_compat_ioctl commands. Also the reason why someone would decide to use Direct I/O with loop devices is well known, that is why the feature exists :) So I thought this was another redundant information to put in the commit message and decided to omit it. If you still think that I should update the commit message with this information, I will do so. Thanks again, Alessio On Tue, Aug 06, 2019 at 06:25:42PM -0400, 'Joel Fernandes' via kernel-team wrote: > Hi Alessio, > > On Tue, Aug 6, 2019 at 6:05 PM Alessio Balsini wrote: > > > > Export LOOP_SET_DIRECT_IO as additional lo_compat_ioctl. > > The input argument for this ioctl is a single long, in the end converted > > to a 1-bit boolean. Compatibility is then preserved. > > > > Cc: Jens Axboe > > Signed-off-by: Alessio Balsini > > This looks Ok to me, but I believe the commit message should also > explain what was this patch "fixing", how was this lack of an "export" > noticed, why does it matter, etc as well. > > thanks, > > - Joel > > > > --- > > drivers/block/loop.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > > index 3036883fc9f8..a7461f482467 100644 > > --- a/drivers/block/loop.c > > +++ b/drivers/block/loop.c > > @@ -1755,6 +1755,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode, > > case LOOP_SET_FD: > > case LOOP_CHANGE_FD: > > case LOOP_SET_BLOCK_SIZE: > > + case LOOP_SET_DIRECT_IO: > > err = lo_ioctl(bdev, mode, cmd, arg); > > break; > > default: > > -- > > 2.22.0.770.g0f2c4a37fd-goog > > > > -- > > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > > > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >