Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] lightnvm: Fix unused variable warning
@ 2019-08-09  9:18 Shaokun Zhang
  2019-08-09 10:38 ` Marcos Paulo de Souza
  0 siblings, 1 reply; 2+ messages in thread
From: Shaokun Zhang @ 2019-08-09  9:18 UTC (permalink / raw)
  To: linux-block; +Cc: Shaokun Zhang, Matias Bjorling, Jens Axboe

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’ [-Wunused-variable]
  struct nvm_geo *geo = &dev->geo;
                  ^
Fixes: ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
Cc: Matias Bjorling <mb@lightnvm.io>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 drivers/lightnvm/pblk-read.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
index 0cdc48f9cfbf..8efd14e683dc 100644
--- a/drivers/lightnvm/pblk-read.c
+++ b/drivers/lightnvm/pblk-read.c
@@ -417,8 +417,6 @@ static int read_rq_gc(struct pblk *pblk, struct nvm_rq *rqd,
 
 int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
 {
-	struct nvm_tgt_dev *dev = pblk->dev;
-	struct nvm_geo *geo = &dev->geo;
 	struct nvm_rq rqd;
 	int ret = NVM_IO_OK;
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] lightnvm: Fix unused variable warning
  2019-08-09  9:18 [PATCH -next] lightnvm: Fix unused variable warning Shaokun Zhang
@ 2019-08-09 10:38 ` Marcos Paulo de Souza
  0 siblings, 0 replies; 2+ messages in thread
From: Marcos Paulo de Souza @ 2019-08-09 10:38 UTC (permalink / raw)
  To: Shaokun Zhang; +Cc: linux-block, Matias Bjorling, Jens Axboe

On Fri, Aug 09, 2019 at 05:18:16PM +0800, Shaokun Zhang wrote:
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’ [-Wunused-variable]
>   struct nvm_geo *geo = &dev->geo;
>                   ^
> Fixes: ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> Cc: Matias Bjorling <mb@lightnvm.io>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  drivers/lightnvm/pblk-read.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
> index 0cdc48f9cfbf..8efd14e683dc 100644
> --- a/drivers/lightnvm/pblk-read.c
> +++ b/drivers/lightnvm/pblk-read.c
> @@ -417,8 +417,6 @@ static int read_rq_gc(struct pblk *pblk, struct nvm_rq *rqd,
>  
>  int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
>  {
> -	struct nvm_tgt_dev *dev = pblk->dev;
> -	struct nvm_geo *geo = &dev->geo;
>  	struct nvm_rq rqd;
>  	int ret = NVM_IO_OK;
>  

Jens went ahead and already fixed this one in for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=f0e6f41669d9e07f45b472e4de33d7c233a847bd

> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  9:18 [PATCH -next] lightnvm: Fix unused variable warning Shaokun Zhang
2019-08-09 10:38 ` Marcos Paulo de Souza

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox