From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7CAC32753 for ; Tue, 13 Aug 2019 10:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 114CF20679 for ; Tue, 13 Aug 2019 10:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbfHMKdQ (ORCPT ); Tue, 13 Aug 2019 06:33:16 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51510 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfHMKdP (ORCPT ); Tue, 13 Aug 2019 06:33:15 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5500180723; Tue, 13 Aug 2019 12:33:01 +0200 (CEST) Date: Tue, 13 Aug 2019 12:33:13 +0200 From: Pavel Machek To: Akinobu Mita Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, Frank Steiner , Jacek Anaszewski , Dan Murphy , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke Subject: Re: [PATCH v3 4/6] block: introduce LED block device activity trigger Message-ID: <20190813103313.GC26337@amd> References: <1565459703-30513-1-git-send-email-akinobu.mita@gmail.com> <1565459703-30513-5-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="da4uJneut+ArUgXk" Content-Disposition: inline In-Reply-To: <1565459703-30513-5-git-send-email-akinobu.mita@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org --da4uJneut+ArUgXk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2019-08-11 02:55:01, Akinobu Mita wrote: > This allows LEDs to be controlled by block device activity. >=20 > We already have ledtrig-disk (LED disk activity trigger), but the lower > level disk drivers need to utilize ledtrig_disk_activity() to make the > LED blink. >=20 > The LED block device trigger doesn't require the lower level drivers to > have any instrumentation. The activity is collected by polling the disk > stats. >=20 > Example: >=20 > echo block-nvme0n1 > /sys/class/leds/diy/trigger Some machines have lots of block devices... Should we perhaps have "echo block > trigger; echo nvme0n1 > device"? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --da4uJneut+ArUgXk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl1SkekACgkQMOfwapXb+vIYIQCcCQatKldtygxinfIx5q0mAEse f7kAn1dmVugrnJLtH409sL+2qgiJx6M0 =x9Iu -----END PGP SIGNATURE----- --da4uJneut+ArUgXk--