From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D275AC32750 for ; Tue, 13 Aug 2019 13:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 995332067D for ; Tue, 13 Aug 2019 13:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="TrdfCmvc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728829AbfHMNLi (ORCPT ); Tue, 13 Aug 2019 09:11:38 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:37706 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728410AbfHMNLi (ORCPT ); Tue, 13 Aug 2019 09:11:38 -0400 Received: by mail-qt1-f195.google.com with SMTP id y26so106260633qto.4 for ; Tue, 13 Aug 2019 06:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q0ylxgOv4N7J3MK96yhPh/s3pBR8tJPHjcHGz1jC9Yw=; b=TrdfCmvcXZMpGELvJgaa29QMziep9hmZNOR39fbKj6fQxmmqzBAOxez/Nx7hKOK46p mDieTioNIdF5/fEQqI7rUvDfHgdnW6gY6W1sPh3GAkTUSQ4xVKNqfk8EL03HOoEMyBbp v/4ru8yNZMMx1xRVkw9YZDLge0QReqPYiOoffLjM5sDcE+udqSveRs59WFOQEkfGrBK+ v5v5kLqlDEWL1agrToz/8bSkZ6PVEn4wO/2fZLx2bMj/wHSHS3ejoDLaAPSsXqKnUvZu r6+IBB7bhktaCNL6GhOsviX6cZnxRqP1oMIOsr2g6ezVXYTlt89pGcZiAaF8tEKiZNWI yUwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q0ylxgOv4N7J3MK96yhPh/s3pBR8tJPHjcHGz1jC9Yw=; b=Qibj9RHGmNwDx0CaPRbTIXtnBWvIhEOQv9v+boSPcni5tGWVne0CrfzJCTsinSD19g aLQyiAUk2OgShMLfl2y5e9dTYv/E3GBYBZNyshCeFrUJp6RcA5iX0T8Rh2xFWawZ0+bc BjiLL5psLaE/pnmROz0/5oZOYEbeewD7z7qG6ce/amb9+Bhli+YsqBCa5oBBR6sV28+h Y3T+9wusBVqPKCAzOh31oEJz+T5bJj6ix36m/clOW0jt5OYAP2iGJDrCBip59zkTlr4f mtIloT11ZMh0szRfprWHU4Gr/eZeg4BvckilgpeVhEb2wQ3YJyAFOMCxab/bH1jWePuZ Xo3A== X-Gm-Message-State: APjAAAUWlGldJD3EOE8T5A43ZZ3/GVnRAl8C0gvpis24bSYBet8YwQYf ULOEe8/H4HBazj/+09oUEaKZ9A== X-Google-Smtp-Source: APXvYqybicxW89AmGzRkUKRXSGAT+2TtqAx0DTqxnLxPOuVrv+QRkjn9gThLuC8FDBGIiv0nuvMNXA== X-Received: by 2002:ac8:1410:: with SMTP id k16mr33303711qtj.335.1565701897154; Tue, 13 Aug 2019 06:11:37 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id 136sm7862831qkg.96.2019.08.13.06.11.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 06:11:36 -0700 (PDT) Date: Tue, 13 Aug 2019 09:11:35 -0400 From: Josef Bacik To: Mike Christie Cc: josef@toxicpanda.com, linux-block@vger.kernel.org Subject: Re: [PATCH 3/4] nbd: add missing config put Message-ID: <20190813131135.lowte3muvdab23q4@MacBook-Pro-91.local> References: <20190809212610.19412-1-mchristi@redhat.com> <20190809212610.19412-4-mchristi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190809212610.19412-4-mchristi@redhat.com> User-Agent: NeoMutt/20180716 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Aug 09, 2019 at 04:26:09PM -0500, Mike Christie wrote: > Fix bug added with the patch: > > commit 8f3ea35929a0806ad1397db99a89ffee0140822a > Author: Josef Bacik > Date: Mon Jul 16 12:11:35 2018 -0400 > > nbd: handle unexpected replies better > > where if the timeout handler runs when the completion path is and we fail > to grab the mutex in the timeout handler we will leave a config reference > and cannot free the config later. > > Signed-off-by: Mike Christie Reviewed-by: Josef Bacik Thanks, Josef