From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6FEC31E40 for ; Thu, 15 Aug 2019 04:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D15D32133F for ; Thu, 15 Aug 2019 04:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725832AbfHOEHq (ORCPT ); Thu, 15 Aug 2019 00:07:46 -0400 Received: from bout01.mta.xmission.com ([166.70.11.15]:55824 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725440AbfHOEHp (ORCPT ); Thu, 15 Aug 2019 00:07:45 -0400 X-Greylist: delayed 350 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Aug 2019 00:07:45 EDT Received: from mx04.mta.xmission.com ([166.70.13.214]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hy73A-0004tc-VC; Wed, 14 Aug 2019 22:07:45 -0600 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx04.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1hy73A-0002wD-6o; Wed, 14 Aug 2019 22:07:44 -0600 Received: from hacktheplanet (unknown [8.25.222.2]) by plesk14.xmission.com (Postfix) with ESMTPSA id C94F472909; Thu, 15 Aug 2019 04:07:43 +0000 (UTC) Date: Thu, 15 Aug 2019 00:07:41 -0400 From: Scott Bauer To: Revanth Rajashekar Cc: linux-block@vger.kernel.org, Jonathan Derrick Message-ID: <20190815040741.GC31938@hacktheplanet> References: <20190813214340.15533-1-revanth.rajashekar@intel.com> <20190813214340.15533-4-revanth.rajashekar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813214340.15533-4-revanth.rajashekar@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1hy73A-0002wD-6o;;;mid=<20190815040741.GC31938@hacktheplanet>;;;hst=mx04.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me Subject: Re: [PATCH 3/3] block: sed-opal: OPAL_METHOD_LENGTH defined twice X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on mx04.mta.xmission.com) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Aug 13, 2019 at 03:43:40PM -0600, Revanth Rajashekar wrote: > Signed-off-by: Revanth Rajashekar Reviewed-by: Scott Bauer Two things, Can we also change the title of this commit to: "Removed duplicate OPAL_METHOD_LENGTH definition" 2nd, I'm dumb as hell now adays, why doesn't this throw a compiler error for multiple declarations?