linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
	Mark Ray <mark.ray@hpe.com>, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] blk-mq: remove blk_mq_hw_sysfs_cpus
Date: Sat, 17 Aug 2019 00:08:51 +0800	[thread overview]
Message-ID: <20190816160826.GB29878@ming.t460p> (raw)
In-Reply-To: <5baa0c28-6e12-5a61-0254-de0e49cf1596@kernel.dk>

On Fri, Aug 16, 2019 at 08:20:42AM -0600, Jens Axboe wrote:
> On 8/16/19 1:48 AM, Ming Lei wrote:
> > It is reported that sysfs buffer overflow can be triggered in case
> > of too many CPU cores(>841 on 4K PAGE_SIZE) when showing CPUs in
> > blk_mq_hw_sysfs_cpus_show().
> > 
> > This info isn't useful, given users may retrieve the CPU list
> > from sw queue entries under same kobject dir, so far not see
> > any active users.
> > 
> > So remove the entry as suggested by Greg.
> 
> I think that's a bit frivolous, there could very well be scripts or
> apps that use it. Let's just fix the overflow.

I am fine with either way.

There are two fixes:

1) without format change:
https://lore.kernel.org/linux-block/c5b1b6f3-d461-9379-7e5c-6c6bee6a7bd5@kernel.dk/T/#t

2) format change:
https://lore.kernel.org/linux-block/20190816070948.GD1368@kroah.com/T/#t

If either one isn't fine, please let me know, and I will cook new one for you.


Thanks,
Ming

      parent reply	other threads:[~2019-08-16 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16  7:48 [PATCH] blk-mq: remove blk_mq_hw_sysfs_cpus Ming Lei
2019-08-16  8:12 ` Greg KH
2019-08-16 14:20 ` Jens Axboe
2019-08-16 14:54   ` Greg KH
2019-08-16 15:12     ` Jens Axboe
2019-08-16 15:21       ` Greg KH
2019-08-16 16:08   ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816160826.GB29878@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=mark.ray@hpe.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).