From: Christoph Hellwig <hch@infradead.org>
To: Martijn Coenen <maco@android.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundatio.org,
kernel-team@android.com, narayan@google.com,
dariofreni@google.com, ioffe@google.com, jiyong@google.com,
maco@google.com
Subject: Re: [PATCH] loop: change queue block size to match when using DIO.
Date: Fri, 30 Aug 2019 08:50:24 -0700 [thread overview]
Message-ID: <20190830155024.GA23882@infradead.org> (raw)
In-Reply-To: <20190828103229.191853-1-maco@android.com>
On Wed, Aug 28, 2019 at 12:32:29PM +0200, Martijn Coenen wrote:
> The loop driver assumes that if the passed in fd is opened with
> O_DIRECT, the caller wants to use direct I/O on the loop device.
> However, if the underlying filesystem has a different block size than
> the loop block queue, direct I/O can't be enabled. Instead of requiring
> userspace to manually change the blocksize and re-enable direct I/O,
> just change the queue block size to match.
Why can't we enable the block device in that case? All the usual
block filesystems support 512 byte aligned direct I/O with a 4k
file system block size (as long as the underlying block device
sector size is also 512 bytes).
next prev parent reply other threads:[~2019-08-30 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 10:32 [PATCH] loop: change queue block size to match when using DIO Martijn Coenen
2019-08-30 15:50 ` Christoph Hellwig [this message]
2019-09-02 19:37 ` Martijn Coenen
2019-09-04 19:49 ` [PATCH v2] " Martijn Coenen
2019-09-10 10:12 ` Martijn Coenen
2019-09-30 8:24 ` Christoph Hellwig
2019-10-01 10:03 ` Martijn Coenen
2019-10-01 14:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830155024.GA23882@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dariofreni@google.com \
--cc=gregkh@linuxfoundatio.org \
--cc=ioffe@google.com \
--cc=jiyong@google.com \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=narayan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).