From: Tejun Heo <tj@kernel.org> To: Paolo Valente <paolo.valente@linaro.org> Cc: Jens Axboe <axboe@kernel.dk>, newella@fb.com, clm@fb.com, Josef Bacik <josef@toxicpanda.com>, dennisz@fb.com, Li Zefan <lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-block <linux-block@vger.kernel.org>, kernel-team@fb.com, cgroups@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, bpf@vger.kernel.org Subject: Re: [PATCHSET block/for-next] IO cost model based work-conserving porportional controller Date: Mon, 2 Sep 2019 08:56:52 -0700 Message-ID: <20190902155652.GH2263813@devbig004.ftw2.facebook.com> (raw) In-Reply-To: <88C7DC68-680E-49BB-9699-509B9B0B12A0@linaro.org> On Mon, Sep 02, 2019 at 05:45:50PM +0200, Paolo Valente wrote: > Thanks for this extra explanations. It is a little bit difficult for > me to understand how the min/max teaks for exactly, but you did give > me the general idea. It just limits how far high and low the IO issue rate, measured in cost, can go. ie. if max is at 200%, the controller won't issue more than twice of what the cost model says 100% is. > Are these results in line with your expectations? If they are, then > I'd like to extend benchmarks to more mixes of workloads. Or should I > try some other QoS configuration first? They aren't. Can you please include the content of io.cost.qos and io.cost.model before each run? Note that partial writes to subset of parameters don't clear other parameters. Thanks. -- tejun
next prev parent reply index Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-14 1:56 Tejun Heo 2019-06-14 1:56 ` [PATCH 01/10] blkcg: pass @q and @blkcg into blkcg_pol_alloc_pd_fn() Tejun Heo 2019-06-14 1:56 ` [PATCH 02/10] blkcg: make ->cpd_init_fn() optional Tejun Heo 2019-06-14 1:56 ` [PATCH 03/10] blkcg: separate blkcg_conf_get_disk() out of blkg_conf_prep() Tejun Heo 2019-06-14 1:56 ` [PATCH 04/10] block/rq_qos: add rq_qos_merge() Tejun Heo 2019-06-14 1:56 ` [PATCH 05/10] block/rq_qos: implement rq_qos_ops->queue_depth_changed() Tejun Heo 2019-06-14 1:56 ` [PATCH 06/10] blkcg: s/RQ_QOS_CGROUP/RQ_QOS_LATENCY/ Tejun Heo 2019-06-14 1:56 ` [PATCH 07/10] blk-mq: add optional request->pre_start_time_ns Tejun Heo 2019-06-14 1:56 ` [PATCH 08/10] blkcg: implement blk-ioweight Tejun Heo 2019-06-14 12:17 ` Toke Høiland-Jørgensen 2019-06-14 15:09 ` Tejun Heo 2019-06-14 20:50 ` Toke Høiland-Jørgensen 2019-06-15 15:57 ` Tejun Heo 2019-06-14 1:56 ` [PATCH 09/10] blkcg: add tools/cgroup/monitor_ioweight.py Tejun Heo 2019-06-14 1:56 ` [PATCH 10/10] blkcg: implement BPF_PROG_TYPE_IO_COST Tejun Heo 2019-06-14 11:32 ` Quentin Monnet 2019-06-14 14:52 ` Tejun Heo 2019-06-14 16:35 ` Alexei Starovoitov 2019-06-14 17:09 ` Tejun Heo 2019-06-14 17:56 ` [PATCHSET block/for-next] IO cost model based work-conserving porportional controller Tejun Heo 2019-08-20 10:48 ` Paolo Valente 2019-08-20 15:04 ` Paolo Valente 2019-08-20 15:19 ` Tejun Heo 2019-08-22 8:58 ` Paolo Valente 2019-08-31 6:53 ` Tejun Heo 2019-08-31 7:10 ` Paolo Valente 2019-08-31 11:20 ` Tejun Heo 2019-09-02 15:45 ` Paolo Valente 2019-09-02 15:56 ` Tejun Heo [this message] 2019-09-02 19:43 ` Paolo Valente 2019-09-05 16:55 ` Tejun Heo 2019-09-06 9:07 ` Paolo Valente 2019-09-06 14:58 ` Tejun Heo 2020-02-19 18:34 ` Paolo Valente
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190902155652.GH2263813@devbig004.ftw2.facebook.com \ --to=tj@kernel.org \ --cc=ast@kernel.org \ --cc=axboe@kernel.dk \ --cc=bpf@vger.kernel.org \ --cc=cgroups@vger.kernel.org \ --cc=clm@fb.com \ --cc=daniel@iogearbox.net \ --cc=dennisz@fb.com \ --cc=hannes@cmpxchg.org \ --cc=josef@toxicpanda.com \ --cc=kafai@fb.com \ --cc=kernel-team@fb.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=newella@fb.com \ --cc=paolo.valente@linaro.org \ --cc=songliubraving@fb.com \ --cc=yhs@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Block Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \ linux-block@vger.kernel.org public-inbox-index linux-block Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block AGPL code for this site: git clone https://public-inbox.org/public-inbox.git