* bcache kbuild cleanups
@ 2019-10-15 16:04 Christoph Hellwig
2019-10-15 16:04 ` [PATCH 1/2] bcache: remove the extra cflags for request.o Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Christoph Hellwig @ 2019-10-15 16:04 UTC (permalink / raw)
To: linux-bcache, linux-block
Hi Coly,
this series removes a pointless cflags override and unused exports
from bcache.
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] bcache: remove the extra cflags for request.o 2019-10-15 16:04 bcache kbuild cleanups Christoph Hellwig @ 2019-10-15 16:04 ` Christoph Hellwig 2019-10-15 16:04 ` [PATCH 2/2] bcache: don't export symbols Christoph Hellwig 2019-10-20 6:24 ` bcache kbuild cleanups Coly Li 2 siblings, 0 replies; 8+ messages in thread From: Christoph Hellwig @ 2019-10-15 16:04 UTC (permalink / raw) To: linux-bcache, linux-block There is no block directory this file needs includes from. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/md/bcache/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/bcache/Makefile b/drivers/md/bcache/Makefile index d26b35195825..fd714628da6a 100644 --- a/drivers/md/bcache/Makefile +++ b/drivers/md/bcache/Makefile @@ -5,5 +5,3 @@ obj-$(CONFIG_BCACHE) += bcache.o bcache-y := alloc.o bset.o btree.o closure.o debug.o extents.o\ io.o journal.o movinggc.o request.o stats.o super.o sysfs.o trace.o\ util.o writeback.o - -CFLAGS_request.o += -Iblock -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] bcache: don't export symbols 2019-10-15 16:04 bcache kbuild cleanups Christoph Hellwig 2019-10-15 16:04 ` [PATCH 1/2] bcache: remove the extra cflags for request.o Christoph Hellwig @ 2019-10-15 16:04 ` Christoph Hellwig 2019-10-20 6:24 ` bcache kbuild cleanups Coly Li 2 siblings, 0 replies; 8+ messages in thread From: Christoph Hellwig @ 2019-10-15 16:04 UTC (permalink / raw) To: linux-bcache, linux-block None of the exported bcache symbols are actually used anywhere. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/md/bcache/bset.c | 15 --------------- drivers/md/bcache/closure.c | 7 ------- 2 files changed, 22 deletions(-) diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c index 08768796b543..a4bab18b2994 100644 --- a/drivers/md/bcache/bset.c +++ b/drivers/md/bcache/bset.c @@ -309,7 +309,6 @@ void bch_btree_keys_free(struct btree_keys *b) t->tree = NULL; t->data = NULL; } -EXPORT_SYMBOL(bch_btree_keys_free); int bch_btree_keys_alloc(struct btree_keys *b, unsigned int page_order, @@ -342,7 +341,6 @@ int bch_btree_keys_alloc(struct btree_keys *b, bch_btree_keys_free(b); return -ENOMEM; } -EXPORT_SYMBOL(bch_btree_keys_alloc); void bch_btree_keys_init(struct btree_keys *b, const struct btree_keys_ops *ops, bool *expensive_debug_checks) @@ -361,7 +359,6 @@ void bch_btree_keys_init(struct btree_keys *b, const struct btree_keys_ops *ops, * any more. */ } -EXPORT_SYMBOL(bch_btree_keys_init); /* Binary tree stuff for auxiliary search trees */ @@ -678,7 +675,6 @@ void bch_bset_init_next(struct btree_keys *b, struct bset *i, uint64_t magic) bch_bset_build_unwritten_tree(b); } -EXPORT_SYMBOL(bch_bset_init_next); /* * Build auxiliary binary tree 'struct bset_tree *t', this tree is used to @@ -732,7 +728,6 @@ void bch_bset_build_written_tree(struct btree_keys *b) j = inorder_next(j, t->size)) make_bfloat(t, j); } -EXPORT_SYMBOL(bch_bset_build_written_tree); /* Insert */ @@ -780,7 +775,6 @@ fix_right: do { j = j * 2 + 1; } while (j < t->size); } -EXPORT_SYMBOL(bch_bset_fix_invalidated_key); static void bch_bset_fix_lookup_table(struct btree_keys *b, struct bset_tree *t, @@ -855,7 +849,6 @@ bool bch_bkey_try_merge(struct btree_keys *b, struct bkey *l, struct bkey *r) return b->ops->key_merge(b, l, r); } -EXPORT_SYMBOL(bch_bkey_try_merge); void bch_bset_insert(struct btree_keys *b, struct bkey *where, struct bkey *insert) @@ -875,7 +868,6 @@ void bch_bset_insert(struct btree_keys *b, struct bkey *where, bkey_copy(where, insert); bch_bset_fix_lookup_table(b, t, where); } -EXPORT_SYMBOL(bch_bset_insert); unsigned int bch_btree_insert_key(struct btree_keys *b, struct bkey *k, struct bkey *replace_key) @@ -931,7 +923,6 @@ copy: bkey_copy(m, k); merged: return status; } -EXPORT_SYMBOL(bch_btree_insert_key); /* Lookup */ @@ -1077,7 +1068,6 @@ struct bkey *__bch_bset_search(struct btree_keys *b, struct bset_tree *t, return i.l; } -EXPORT_SYMBOL(__bch_bset_search); /* Btree iterator */ @@ -1132,7 +1122,6 @@ struct bkey *bch_btree_iter_init(struct btree_keys *b, { return __bch_btree_iter_init(b, iter, search, b->set); } -EXPORT_SYMBOL(bch_btree_iter_init); static inline struct bkey *__bch_btree_iter_next(struct btree_iter *iter, btree_iter_cmp_fn *cmp) @@ -1165,7 +1154,6 @@ struct bkey *bch_btree_iter_next(struct btree_iter *iter) return __bch_btree_iter_next(iter, btree_iter_cmp); } -EXPORT_SYMBOL(bch_btree_iter_next); struct bkey *bch_btree_iter_next_filter(struct btree_iter *iter, struct btree_keys *b, ptr_filter_fn fn) @@ -1196,7 +1184,6 @@ int bch_bset_sort_state_init(struct bset_sort_state *state, return mempool_init_page_pool(&state->pool, 1, page_order); } -EXPORT_SYMBOL(bch_bset_sort_state_init); static void btree_mergesort(struct btree_keys *b, struct bset *out, struct btree_iter *iter, @@ -1313,7 +1300,6 @@ void bch_btree_sort_partial(struct btree_keys *b, unsigned int start, EBUG_ON(oldsize >= 0 && bch_count_data(b) != oldsize); } -EXPORT_SYMBOL(bch_btree_sort_partial); void bch_btree_sort_and_fix_extents(struct btree_keys *b, struct btree_iter *iter, @@ -1366,7 +1352,6 @@ void bch_btree_sort_lazy(struct btree_keys *b, struct bset_sort_state *state) out: bch_bset_build_written_tree(b); } -EXPORT_SYMBOL(bch_btree_sort_lazy); void bch_btree_keys_stats(struct btree_keys *b, struct bset_stats *stats) { diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c index c12cd809ab19..0164a1fe94a9 100644 --- a/drivers/md/bcache/closure.c +++ b/drivers/md/bcache/closure.c @@ -45,7 +45,6 @@ void closure_sub(struct closure *cl, int v) { closure_put_after_sub(cl, atomic_sub_return(v, &cl->remaining)); } -EXPORT_SYMBOL(closure_sub); /* * closure_put - decrement a closure's refcount @@ -54,7 +53,6 @@ void closure_put(struct closure *cl) { closure_put_after_sub(cl, atomic_dec_return(&cl->remaining)); } -EXPORT_SYMBOL(closure_put); /* * closure_wake_up - wake up all closures on a wait list, without memory barrier @@ -76,7 +74,6 @@ void __closure_wake_up(struct closure_waitlist *wait_list) closure_sub(cl, CLOSURE_WAITING + 1); } } -EXPORT_SYMBOL(__closure_wake_up); /** * closure_wait - add a closure to a waitlist @@ -96,7 +93,6 @@ bool closure_wait(struct closure_waitlist *waitlist, struct closure *cl) return true; } -EXPORT_SYMBOL(closure_wait); struct closure_syncer { struct task_struct *task; @@ -131,7 +127,6 @@ void __sched __closure_sync(struct closure *cl) __set_current_state(TASK_RUNNING); } -EXPORT_SYMBOL(__closure_sync); #ifdef CONFIG_BCACHE_CLOSURES_DEBUG @@ -149,7 +144,6 @@ void closure_debug_create(struct closure *cl) list_add(&cl->all, &closure_list); spin_unlock_irqrestore(&closure_list_lock, flags); } -EXPORT_SYMBOL(closure_debug_create); void closure_debug_destroy(struct closure *cl) { @@ -162,7 +156,6 @@ void closure_debug_destroy(struct closure *cl) list_del(&cl->all); spin_unlock_irqrestore(&closure_list_lock, flags); } -EXPORT_SYMBOL(closure_debug_destroy); static struct dentry *closure_debug; -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: bcache kbuild cleanups 2019-10-15 16:04 bcache kbuild cleanups Christoph Hellwig 2019-10-15 16:04 ` [PATCH 1/2] bcache: remove the extra cflags for request.o Christoph Hellwig 2019-10-15 16:04 ` [PATCH 2/2] bcache: don't export symbols Christoph Hellwig @ 2019-10-20 6:24 ` Coly Li 2 siblings, 0 replies; 8+ messages in thread From: Coly Li @ 2019-10-20 6:24 UTC (permalink / raw) To: Christoph Hellwig; +Cc: linux-bcache, linux-block On 2019/10/16 12:04 上午, Christoph Hellwig wrote: > Hi Coly, > > this series removes a pointless cflags override and unused exports > from bcache. > Sure, I add them in my for-next series. Thansk. -- Coly Li ^ permalink raw reply [flat|nested] 8+ messages in thread
* bcache kbuild cleanups @ 2019-12-09 9:38 Christoph Hellwig 2019-12-09 9:59 ` Coly Li 0 siblings, 1 reply; 8+ messages in thread From: Christoph Hellwig @ 2019-12-09 9:38 UTC (permalink / raw) To: colyli; +Cc: kent.overstreet, liangchen.linux, linux-bcache, linux-block Hi Coly and Liang, can you review this series to sort out the bcache superblock reading for larger page sizes? I don't have bcache test setup so this is compile tested only. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bcache kbuild cleanups 2019-12-09 9:38 Christoph Hellwig @ 2019-12-09 9:59 ` Coly Li 2019-12-11 15:17 ` Liang C 0 siblings, 1 reply; 8+ messages in thread From: Coly Li @ 2019-12-09 9:59 UTC (permalink / raw) To: Christoph Hellwig Cc: kent.overstreet, liangchen.linux, linux-bcache, linux-block On 2019/12/9 5:38 下午, Christoph Hellwig wrote: > Hi Coly and Liang, > > can you review this series to sort out the bcache superblock reading for > larger page sizes? I don't have bcache test setup so this is compile > tested only. > Hi Christoph, At first glance the patches are good. I will add them into my for-test directory and test with other development patches. Thanks for handling this. -- Coly Li ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bcache kbuild cleanups 2019-12-09 9:59 ` Coly Li @ 2019-12-11 15:17 ` Liang C 2019-12-12 15:34 ` Christoph Hellwig 0 siblings, 1 reply; 8+ messages in thread From: Liang C @ 2019-12-11 15:17 UTC (permalink / raw) To: Christoph Hellwig; +Cc: Coly Li, Kent Overstreet, linux-bcache, linux-block > Hi Coly and Liang, > > can you review this series to sort out the bcache superblock reading for > larger page sizes? I don't have bcache test setup so this is compile > tested only. > Hi Christoph, Thanks for making the patches. I looked through them, but didn't see where cache and cached_dev have their sb_disk assigned. That would be an issue when __write_super tries to add the corresponding page to the bio. Not sure if there is there anything I missed. Liang ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bcache kbuild cleanups 2019-12-11 15:17 ` Liang C @ 2019-12-12 15:34 ` Christoph Hellwig 0 siblings, 0 replies; 8+ messages in thread From: Christoph Hellwig @ 2019-12-12 15:34 UTC (permalink / raw) To: Liang C Cc: Christoph Hellwig, Coly Li, Kent Overstreet, linux-bcache, linux-block On Wed, Dec 11, 2019 at 11:17:44PM +0800, Liang C wrote: > > Hi Coly and Liang, > > > > can you review this series to sort out the bcache superblock reading for > > larger page sizes? I don't have bcache test setup so this is compile > > tested only. > > > Hi Christoph, > > Thanks for making the patches. I looked through them, but didn't see > where cache and cached_dev have their sb_disk assigned. > That would be an issue when __write_super tries to add the > corresponding page to the bio. Not sure if there is there anything I > missed. Yes, that was missing. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-12 15:34 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-15 16:04 bcache kbuild cleanups Christoph Hellwig 2019-10-15 16:04 ` [PATCH 1/2] bcache: remove the extra cflags for request.o Christoph Hellwig 2019-10-15 16:04 ` [PATCH 2/2] bcache: don't export symbols Christoph Hellwig 2019-10-20 6:24 ` bcache kbuild cleanups Coly Li 2019-12-09 9:38 Christoph Hellwig 2019-12-09 9:59 ` Coly Li 2019-12-11 15:17 ` Liang C 2019-12-12 15:34 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).