linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
	axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: skip the split micro-optimization for devices with chunk size
Date: Tue, 5 Nov 2019 01:18:30 +0100	[thread overview]
Message-ID: <20191105001830.GA27112@lst.de> (raw)
In-Reply-To: <2ac3f0c3-1454-3246-37a5-695a13319b8c@acm.org>

On Mon, Nov 04, 2019 at 04:14:10PM -0800, Bart Van Assche wrote:
> On 11/4/19 4:06 PM, Christoph Hellwig wrote:
>> If the devices sets a chunk size we might have to split I/O that is
>> smaller than a page size if it crosses the chunk boundary.  Skip the
>> micro-optimization for small I/Os in that case.
>>
>> Fixes: b072e20f0084 ("block: merge invalidate_partitions into rescan_partitions")
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>>   block/blk-merge.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/blk-merge.c b/block/blk-merge.c
>> index 06eb38357b41..f22cb6251d06 100644
>> --- a/block/blk-merge.c
>> +++ b/block/blk-merge.c
>> @@ -317,7 +317,8 @@ void __blk_queue_split(struct request_queue *q, struct bio **bio,
>>   		 * are cloned, but compared to the performance impact of cloned
>>   		 * bios themselves the loop below doesn't matter anyway.
>                                        ^^^^
> Did you perhaps mean "test" instead of "loop"?

No. I did mean the loop in blk_bio_segment_split.

      reply	other threads:[~2019-11-05  0:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  0:06 [PATCH] block: skip the split micro-optimization for devices with chunk size Christoph Hellwig
2019-11-05  0:10 ` Jens Axboe
2019-11-05  0:14 ` Bart Van Assche
2019-11-05  0:18   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105001830.GA27112@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).