From: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
USB list <linux-usb@vger.kernel.org>,
linux-block@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: reeze while write on external usb 3.0 hard disk [Bug 204095]
Date: Sat, 9 Nov 2019 00:05:36 +0100 [thread overview]
Message-ID: <20191108230536.GA11931@lazy.lzy> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1910171522200.18407-100000@netrider.rowland.org>
On Thu, Oct 17, 2019 at 03:23:34PM -0400, Alan Stern wrote:
> On Thu, 17 Oct 2019, Piergiorgio Sartor wrote:
>
> > > Here is one more thing you can try. I have no idea whether it will
> > > make any difference, but the Changelog entry for the patch you
> > > identified suggests that it might help.
> > >
> > > Alan Stern
> > >
> > >
> > >
> > > Index: usb-devel/drivers/usb/storage/scsiglue.c
> > > ===================================================================
> > > --- usb-devel.orig/drivers/usb/storage/scsiglue.c
> > > +++ usb-devel/drivers/usb/storage/scsiglue.c
> > > @@ -68,7 +68,6 @@ static const char* host_info(struct Scsi
> > > static int slave_alloc (struct scsi_device *sdev)
> > > {
> > > struct us_data *us = host_to_us(sdev->host);
> > > - int maxp;
> > >
> > > /*
> > > * Set the INQUIRY transfer length to 36. We don't use any of
> > > @@ -78,15 +77,6 @@ static int slave_alloc (struct scsi_devi
> > > sdev->inquiry_len = 36;
> > >
> > > /*
> > > - * USB has unusual scatter-gather requirements: the length of each
> > > - * scatterlist element except the last must be divisible by the
> > > - * Bulk maxpacket value. Fortunately this value is always a
> > > - * power of 2. Inform the block layer about this requirement.
> > > - */
> > > - maxp = usb_maxpacket(us->pusb_dev, us->recv_bulk_pipe, 0);
> > > - blk_queue_virt_boundary(sdev->request_queue, maxp - 1);
> > > -
> > > - /*
> > > * Some host controllers may have alignment requirements.
> > > * We'll play it safe by requiring 512-byte alignment always.
> > > */
> >
> > Hi,
> >
> > I tested the patch.
> >
> > Assumming I did everything properly, add patch,
> > test, issue not showing up, remove patch, re-test,
> > issue present.
> >
> > It seems this patch you provide solves the issue.
> >
> > Thanks a lot for the support and the solution.
> >
> > I guess now this patch will be integrated into
> > mainline sometimes.
> > Please let me know, in this thread or directly, in
> > which kernel it will be available.
>
> I'm busy for the next few days, but I will submit the patch next week.
Hi again,
this message to let you know I tested
kernel 5.3.9 (always from Fedora), to
which Greg Kroah-Hartman added your
patch, and everything seems to work
fine, no problems detected so far.
Thanks,
bye,
--
piergiorgio
prev parent reply other threads:[~2019-11-08 23:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190817095422.GA4200@lazy.lzy>
2019-08-19 14:14 ` reeze while write on external usb 3.0 hard disk [Bug 204095] Alan Stern
2019-08-20 7:23 ` Christoph Hellwig
2019-08-20 16:37 ` Piergiorgio Sartor
2019-08-26 17:38 ` Piergiorgio Sartor
2019-08-29 14:08 ` Christoph Hellwig
2019-09-25 17:07 ` Piergiorgio Sartor
2019-09-25 18:31 ` Alan Stern
2019-09-27 9:04 ` Peter Chen
2019-09-29 20:13 ` Piergiorgio Sartor
2019-09-30 1:01 ` Alan Stern
2019-09-30 18:25 ` Piergiorgio Sartor
2019-10-13 18:11 ` Piergiorgio Sartor
2019-10-16 17:01 ` Alan Stern
2019-10-17 17:53 ` Piergiorgio Sartor
2019-10-17 19:23 ` Alan Stern
2019-11-08 23:05 ` Piergiorgio Sartor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108230536.GA11931@lazy.lzy \
--to=piergiorgio.sartor@nexgo.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).