From: Revanth Rajashekar <revanth.rajashekar@intel.com>
To: <linux-block@vger.kernel.org>
Cc: Scott Bauer <sbauer@plzdonthack.me>,
Jonathan Derrick <jonathan.derrick@intel.com>,
Jens Axboe <axboe@kernel.dk>,
Revanth Rajashekar <revanth.rajashekar@intel.com>
Subject: [PATCH] block: sed-opal: Introduce SUM_SET_LIST parameter and append it using 'add_token_u64'
Date: Fri, 8 Nov 2019 16:09:04 -0700 [thread overview]
Message-ID: <20191108230904.7932-1-revanth.rajashekar@intel.com> (raw)
In function 'activate_lsp', rather than hard-coding the
short atom header(0x83), we need to let the function
'add_short_atom_header' append the header based on the
parameter being appended.
The paramete has been defined in Section 3.1.2.1 of
https://trustedcomputinggroup.org/wp-content/uploads/TCG_Storage-Opal_Feature_Set_Single_User_Mode_v1-00_r1-00-Final.pdf
Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
---
block/opal_proto.h | 4 ++++
block/sed-opal.c | 6 +-----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/opal_proto.h b/block/opal_proto.h
index 736e67c3e7c5..325cbba2465f 100644
--- a/block/opal_proto.h
+++ b/block/opal_proto.h
@@ -205,6 +205,10 @@ enum opal_lockingstate {
OPAL_LOCKING_LOCKED = 0x03,
};
+enum opal_parameter {
+ OPAL_SUM_SET_LIST = 0x060000,
+};
+
/* Packets derived from:
* TCG_Storage_Architecture_Core_Spec_v2.01_r1.00
* Secion: 3.2.3 ComPackets, Packets & Subpackets
diff --git a/block/sed-opal.c b/block/sed-opal.c
index b2cacc9ddd11..880cc57a5f6b 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -1886,7 +1886,6 @@ static int activate_lsp(struct opal_dev *dev, void *data)
{
struct opal_lr_act *opal_act = data;
u8 user_lr[OPAL_UID_LENGTH];
- u8 uint_3 = 0x83;
int err, i;
err = cmd_start(dev, opaluid[OPAL_LOCKINGSP_UID],
@@ -1899,10 +1898,7 @@ static int activate_lsp(struct opal_dev *dev, void *data)
return err;
add_token_u8(&err, dev, OPAL_STARTNAME);
- add_token_u8(&err, dev, uint_3);
- add_token_u8(&err, dev, 6);
- add_token_u8(&err, dev, 0);
- add_token_u8(&err, dev, 0);
+ add_token_u64(&err, dev, OPAL_SUM_SET_LIST);
add_token_u8(&err, dev, OPAL_STARTLIST);
add_token_bytestring(&err, dev, user_lr, OPAL_UID_LENGTH);
--
2.17.1
next reply other threads:[~2019-11-08 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 23:09 Revanth Rajashekar [this message]
2019-11-14 16:14 ` [PATCH] block: sed-opal: Introduce SUM_SET_LIST parameter and append it using 'add_token_u64' Rajashekar, Revanth
2019-11-14 17:28 ` Jens Axboe
2019-11-14 18:19 ` Rajashekar, Revanth
2019-11-18 16:47 ` Derrick, Jonathan
2019-11-18 16:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108230904.7932-1-revanth.rajashekar@intel.com \
--to=revanth.rajashekar@intel.com \
--cc=axboe@kernel.dk \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=sbauer@plzdonthack.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).