linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: <axboe@kernel.dk>, <sjpark@amazon.com>, <konrad.wilk@oracle.com>,
	<pdurrant@amazon.com>, SeongJae Park <sjpark@amazon.de>,
	<linux-kernel@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH v5 1/2] xenbus/backend: Add memory pressure handler callback
Date: Tue, 10 Dec 2019 11:21:49 +0100	[thread overview]
Message-ID: <20191210102023.GF980@Air-de-Roger> (raw)
In-Reply-To: <20191210101635.GD980@Air-de-Roger>

On Tue, Dec 10, 2019 at 11:16:35AM +0100, Roger Pau Monné wrote:
> On Tue, Dec 10, 2019 at 08:06:27AM +0000, SeongJae Park wrote:
> > diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
> > index 869c816d5f8c..cdb075e4182f 100644
> > --- a/include/xen/xenbus.h
> > +++ b/include/xen/xenbus.h
> > @@ -104,6 +104,7 @@ struct xenbus_driver {
> >  	struct device_driver driver;
> >  	int (*read_otherend_details)(struct xenbus_device *dev);
> >  	int (*is_ready)(struct xenbus_device *dev);
> > +	unsigned (*reclaim)(struct xenbus_device *dev);
> 
> ... hence I wonder why it's returning an unsigned when it's just
> ignored.
> 
> IMO it should return an int to signal errors, and the return should be
> ignored.

Meant to write 'shouldn't be ignored' sorry.

Roger.

  reply	other threads:[~2019-12-10 10:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10  8:06 [PATCH v5 0/2] xenbus/backend: Add a memory pressure handler callback SeongJae Park
2019-12-10  8:06 ` [PATCH v5 1/2] xenbus/backend: Add " SeongJae Park
2019-12-10  8:17   ` Jürgen Groß
2019-12-10 10:16   ` Roger Pau Monné
2019-12-10 10:21     ` Roger Pau Monné [this message]
2019-12-10 10:24       ` [Xen-devel] " SeongJae Park
2019-12-11  3:50     ` SeongJae Park
2019-12-11 10:51       ` Roger Pau Monné
2019-12-11 11:52         ` SeongJae Park
2019-12-10  8:06 ` [PATCH v5 2/2] xen/blkback: Squeeze page pools if a memory pressure is detected SeongJae Park
2019-12-10 11:04   ` Roger Pau Monné
2019-12-11  4:08     ` SeongJae Park
2019-12-11 11:14       ` Roger Pau Monné
2019-12-11 11:52         ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210102023.GF980@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=axboe@kernel.dk \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pdurrant@amazon.com \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.com \
    --cc=sjpark@amazon.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).