linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: renxudong <renxudong1@huawei.com>
Cc: Bob Liu <bob.liu@oracle.com>,
	Zhiqiang Liu <liuzhiqiang26@huawei.com>,
	Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, jens.axboe@oracle.com,
	namhyung@gmail.com, bharrosh@panasas.com,
	Mingfangsen <mingfangsen@huawei.com>,
	zhengbin13@huawei.com, Guiyao <guiyao@huawei.com>,
	ming.lei@redhat.com
Subject: Re: [PATCH] blk-map: add kernel address validation in blk_rq_map_kern func
Date: Wed, 8 Jan 2020 07:07:38 -0800	[thread overview]
Message-ID: <20200108150738.GB18991@infradead.org> (raw)
In-Reply-To: <bc469dc8-19b6-d979-c061-075e52a355b0@huawei.com>

On Tue, Jan 07, 2020 at 02:51:04PM +0800, renxudong wrote:
> When we issued scsi cmd, oops occurred. The call stack was as follows.
> Call trace:
>  __memcpy+0x110/0x180
>  bio_endio+0x118/0x190
>  blk_update_request+0x94/0x378
>  scsi_end_request+0x48/0x2a8
>  scsi_io_completion+0xa4/0x6d0
>  scsi_finish_command+0xd4/0x138
>  scsi_softirq_done+0x13c/0x198
>  blk_done_softirq+0xc4/0x108
>  __do_softirq+0x120/0x324
>  run_ksoftirqd+0x44/0x60
>  smpboot_thread_fn+0x1ac/0x1e8
>  kthread+0x134/0x138
>  ret_from_fork+0x10/0x18
>  Since oops is in the process of scsi cmd done, we have not added oops info
> to the commit log.

What workload is this?  If the address is freed while the I/O is
in progress we have much deeper problem than what a virt_addr_valid
could paper over.

  reply	other threads:[~2020-01-08 15:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 12:17 [PATCH] blk-map: add kernel address validation in blk_rq_map_kern func Zhiqiang Liu
2020-01-07  2:38 ` Zhiqiang Liu
2020-01-07  4:05   ` Bob Liu
2020-01-07  6:51     ` renxudong
2020-01-08 15:07       ` Christoph Hellwig [this message]
2020-01-12  0:18         ` Bart Van Assche
2020-01-13  6:32           ` renxudong
2020-01-13  3:53         ` renxudong
2020-01-07  4:02 ` Jens Axboe
2020-01-08 13:31 ` Christoph Hellwig
2020-01-13  3:22   ` renxudong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108150738.GB18991@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=bharrosh@panasas.com \
    --cc=bob.liu@oracle.com \
    --cc=guiyao@huawei.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=ming.lei@redhat.com \
    --cc=mingfangsen@huawei.com \
    --cc=namhyung@gmail.com \
    --cc=renxudong1@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).