From: Keith Busch <kbusch@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, damien.lemoal@wdc.com
Subject: Re: [PATCH] block: support arbitrary zone size
Date: Tue, 11 Feb 2020 07:33:08 +0900 [thread overview]
Message-ID: <20200210223308.GA20507@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20200210220816.GA7769@avx2>
On Tue, Feb 11, 2020 at 01:08:16AM +0300, Alexey Dobriyan wrote:
> void blk_queue_chunk_sectors(struct request_queue *q, unsigned int chunk_sectors)
> {
> - BUG_ON(!is_power_of_2(chunk_sectors));
> q->limits.chunk_sectors = chunk_sectors;
> }
This breaks blk_max_size_offset() if the value isn't a power of 2,
but I wouldn't want to replace its cheap mask with an expensive divide
operation anyway. Please keep the power-of-2 requirement.
prev parent reply other threads:[~2020-02-10 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 22:08 [PATCH] block: support arbitrary zone size Alexey Dobriyan
2020-02-10 22:20 ` [PATCH v2] " Alexey Dobriyan
2020-02-10 22:57 ` Damien Le Moal
2020-02-10 23:06 ` Martin K. Petersen
2020-02-10 23:28 ` Matias Bjørling
2020-02-11 17:16 ` Alexey Dobriyan
2020-02-11 9:16 ` Javier González
2020-02-12 20:00 ` Christoph Hellwig
2020-02-10 22:23 ` [PATCH] " Bart Van Assche
2020-02-10 22:33 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210223308.GA20507@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).