From: Ming Lei <ming.lei@redhat.com>
To: Jesse Barnes <jsbarnes@google.com>
Cc: Salman Qazi <sqazi@google.com>, Ming Lei <tom.leiming@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Gwendal Grignou <gwendal@google.com>
Subject: Re: BLKSECDISCARD ioctl and hung tasks
Date: Wed, 19 Feb 2020 10:54:56 +0800 [thread overview]
Message-ID: <20200219025456.GD31488@ming.t460p> (raw)
In-Reply-To: <CAJmaN=miqzhnZUTqaTOPp+OWY8+QYhXoE=h5apSucMkEU4nvtA@mail.gmail.com>
On Tue, Feb 18, 2020 at 08:11:53AM -0800, Jesse Barnes wrote:
> On Fri, Feb 14, 2020 at 7:47 PM Ming Lei <ming.lei@redhat.com> wrote:
> > What are the 'other operations'? Are they block IOs?
> >
> > If yes, that is why I suggest to fix submit_bio_wait(), which should cover
> > most of sync bio submission.
> >
> > Anyway, the fix is simple & generic enough, I'd plan to post a formal
> > patch if no one figures out better doable approaches.
>
> Yeah I think any block I/O operation that occurs after the
> BLKSECDISCARD is submitted will also potentially be affected by the
> hung task timeouts, and I think your patch will address that. My only
> concern with it is that it might hide some other I/O "hangs" that are
> due to device misbehavior instead. Yes driver and device timeouts
> should generally catch those, but with this in place we might miss a
> few bugs.
>
> Given the nature of these types of storage devices though, I think
> that's a minor issue and not worth blocking the patch on, given that
> it should prevent a lot of false positive hang reports as Salman
> demonstrated.
Hello Jesse and Salman,
One more question about this issue, do you enable BLK_WBT on your test
kernel?
Thanks,
Ming
next prev parent reply other threads:[~2020-02-19 2:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 22:27 BLKSECDISCARD ioctl and hung tasks Salman Qazi
2020-02-12 23:06 ` Theodore Y. Ts'o
2020-02-13 1:20 ` Salman Qazi
2020-02-13 1:24 ` Jesse Barnes
2020-02-13 8:26 ` Ming Lei
2020-02-13 17:48 ` Bart Van Assche
2020-02-13 19:21 ` Salman Qazi
2020-02-13 22:08 ` Salman Qazi
2020-02-14 0:25 ` Ming Lei
2020-02-14 5:49 ` Bart Van Assche
2020-02-14 9:22 ` Ming Lei
2020-02-14 19:42 ` Salman Qazi
2020-02-15 3:46 ` Ming Lei
2020-02-18 16:11 ` Jesse Barnes
2020-02-19 1:37 ` Ming Lei
2020-02-19 2:54 ` Ming Lei [this message]
2020-02-19 17:54 ` Salman Qazi
2020-02-19 22:22 ` Ming Lei
2020-02-19 22:26 ` Salman Qazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219025456.GD31488@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gwendal@google.com \
--cc=hch@lst.de \
--cc=jsbarnes@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sqazi@google.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).