From: Omar Sandoval <osandov@osandov.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: osandov@fb.com, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH blktests V2 1/3] nvme: allow target to set cntlid min/max & model
Date: Wed, 4 Mar 2020 17:32:41 -0800 [thread overview]
Message-ID: <20200305013241.GB293405@vader> (raw)
In-Reply-To: <20200215013831.6715-2-chaitanya.kulkarni@wdc.com>
On Fri, Feb 14, 2020 at 05:38:29PM -0800, Chaitanya Kulkarni wrote:
> This patch updates helper function create_nvmet_subsystem() to handle
> newly introduced model, cntlid_min and cntlid_max attributes.
> Also, this adds SKIP reason when attributes are not found in the
> configfs.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> tests/nvme/rc | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 40f0413..e4b57cb 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -121,11 +121,36 @@ _create_nvmet_subsystem() {
> local nvmet_subsystem="$1"
> local blkdev="$2"
> local uuid=$3
> + local cntlid_min=$4
> + local cntlid_max=$5
> + local model=$6
> local cfs_path="${NVMET_CFS}/subsystems/${nvmet_subsystem}"
>
> mkdir -p "${cfs_path}"
> echo 1 > "${cfs_path}/attr_allow_any_host"
> +
> + if [ $# -eq 5 ]; then
I still don't like that we ignore this if we also pass the model.
Instead, just make this
if [[ -n $cntlid ]]
Then the caller can pass an empty argument if they want it ignored.
> + if [ -f "${cfs_path}"/attr_cntlid_min ]; then
> + echo "${cntlid_min}" > "${cfs_path}"/attr_cntlid_min
> + echo "${cntlid_max}" > "${cfs_path}"/attr_cntlid_max
> + else
> + SKIP_REASON="attr_cntlid_[min|max] not found"
> + rmdir "${cfs_path}"
> + return 1
> + fi
> + fi
next prev parent reply other threads:[~2020-03-05 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 1:38 [PATCH blktests V2 0/3] nvme: add cntlid and model testcases Chaitanya Kulkarni
2020-02-15 1:38 ` [PATCH blktests V2 1/3] nvme: allow target to set cntlid min/max & model Chaitanya Kulkarni
2020-03-05 1:32 ` Omar Sandoval [this message]
2020-02-15 1:38 ` [PATCH blktests V2 2/3] nvme: test target cntlid min cntlid max Chaitanya Kulkarni
2020-03-05 1:30 ` Omar Sandoval
2020-03-05 1:55 ` Chaitanya Kulkarni
2020-02-15 1:38 ` [PATCH blktests V2 3/3] nvme: test target model attribute Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305013241.GB293405@vader \
--to=osandov@osandov.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).