From: Omar Sandoval <osandov@osandov.com>
To: Sun Ke <sunke32@huawei.com>
Cc: linux-block@vger.kernel.org, osandov@fb.com
Subject: Re: [PATCH blktests] nbd/003: improve the test
Date: Wed, 4 Mar 2020 17:35:54 -0800 [thread overview]
Message-ID: <20200305013554.GC293405@vader> (raw)
In-Reply-To: <20200224042728.31886-1-sunke32@huawei.com>
On Mon, Feb 24, 2020 at 12:27:28PM +0800, Sun Ke wrote:
> Modify the DESCRIPTION, remove the umount and add rm.
>
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---
> tests/nbd/003 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/nbd/003 b/tests/nbd/003
> index 57fb63a..49ca30e 100644
> --- a/tests/nbd/003
> +++ b/tests/nbd/003
> @@ -7,7 +7,7 @@
>
> . tests/nbd/rc
>
> -DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
> +DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
> QUICK=1
>
> requires() {
> @@ -23,8 +23,8 @@ test() {
>
> mkdir -p "${TMPDIR}/mnt"
> src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
> - umount "${TMPDIR}/mnt" > /dev/null 2>&1
Is the umount causing problems?
>
> nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
> + rm -rf "${TMPDIR}/mnt"
The test harness already removes the TMPDIR directory. Why is this
necessary?
next prev parent reply other threads:[~2020-03-05 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 4:27 [PATCH blktests] nbd/003: improve the test Sun Ke
2020-03-05 1:35 ` Omar Sandoval [this message]
2020-03-05 8:43 ` sunke (E)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305013554.GC293405@vader \
--to=osandov@osandov.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).