From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9CFC10DCE for ; Thu, 12 Mar 2020 12:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B160206EB for ; Thu, 12 Mar 2020 12:03:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="f6V4M7Hj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726395AbgCLMDE (ORCPT ); Thu, 12 Mar 2020 08:03:04 -0400 Received: from mail-qv1-f66.google.com ([209.85.219.66]:38866 "EHLO mail-qv1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbgCLMDE (ORCPT ); Thu, 12 Mar 2020 08:03:04 -0400 Received: by mail-qv1-f66.google.com with SMTP id p60so2435811qva.5 for ; Thu, 12 Mar 2020 05:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g1Wdzvpjgq0rmXr47VZEoreiXSWsPwwFS/Fg+1mqi9I=; b=f6V4M7Hj/YKRgFvnQ0ip1pwXT/78X97E4YMfS3/VrzK3Dc9eizGIcR05Sb+2NADqtC j/ZGjHCtaX/0DSsBpUED0TJCcyC3MjcD/3wuKE/qrEiQ1roSL7/LFdD4HqGNG8CORa7u wJHJp6PcbrXDdqjM6PGcCeoy40bnT52dACFfAGtHnMWLDiAfAXgCsbzQmzRQAdrvzXEG CYKssZ+zrnfq6xM0TGQ5KhgU+rNcqPoUq5etc6Gb/HpoPEThuzHg2LbYr5PgS5IL7wK8 AA3Mi7oUwJCp2UB7a00mC6qImnG6RV1wFF0P8IIxs1HsFz0srIM4/UAn+Pk27Wqdsel6 DYIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g1Wdzvpjgq0rmXr47VZEoreiXSWsPwwFS/Fg+1mqi9I=; b=CgXRo1zB9Yd6u/UnZsPgHiXgoPIswiB+J0wUiL2Nbka6akJYYwqKu4tqf9ZCbvGZ/e v9qFz4wT/hHJxm1eco2Ov0RIBTX5Rljar+TeZJYRHQlc3uZT4BIM10k8YzUE1w2Dnx53 CQauIyRVqFaDJx0QZ5ATnTyur+1no2UDywv3XQmdsMq05sCIWCrS9l/M7lDdJbhxf8yS mNlF4ztOaGMj1wzaIF4v5HwMSIgA+JwbVJA2Jsf0J4TUyrMME3n3gXYXoVvsi11q2/K+ qsLRRauivIYKhCnNL1LrMoUdkbj0pf9mCACRAH/g2LasRPm7CLVfVJXB5OKr2B+fctKT WnHg== X-Gm-Message-State: ANhLgQ3K3SFIwy5Aqy918FakDV0AliEVDf2LhKEwVVQZez/7gyb+SzRI yKu3AZjyGxOEElgjqmiDOjKRyQ== X-Google-Smtp-Source: ADFU+vtcfzf9wRVww1Ak9MPTXQ7fpkzfVrarAblgpse0DpS7sRPucb1fwZUXlmxYkAKCsOzJdNKfCA== X-Received: by 2002:a0c:ffd3:: with SMTP id h19mr6933623qvv.166.1584014582927; Thu, 12 Mar 2020 05:03:02 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id w204sm14610945qkb.133.2020.03.12.05.03.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Mar 2020 05:03:01 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jCMYG-0004u9-4k; Thu, 12 Mar 2020 09:03:00 -0300 Date: Thu, 12 Mar 2020 09:03:00 -0300 From: Jason Gunthorpe To: Danil Kipnis Cc: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Bart Van Assche , Leon Romanovsky , Doug Ledford , Roman Penyaev , Pankaj Gupta Subject: Re: [PATCH v10 13/26] RDMA/rtrs: include client and server modules into kernel compilation Message-ID: <20200312120300.GJ31668@ziepe.ca> References: <20200311161240.30190-1-jinpu.wang@cloud.ionos.com> <20200311161240.30190-14-jinpu.wang@cloud.ionos.com> <20200311190313.GI31668@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Mar 12, 2020 at 11:50:59AM +0100, Danil Kipnis wrote: > On Wed, Mar 11, 2020 at 8:03 PM Jason Gunthorpe wrote: > > > > On Wed, Mar 11, 2020 at 05:12:27PM +0100, Jack Wang wrote: > > > Add rtrs Makefile, Kconfig and also corresponding lines into upper > > > layer infiniband/ulp files. > > > > > > Signed-off-by: Danil Kipnis > > > Signed-off-by: Jack Wang > > > drivers/infiniband/Kconfig | 1 + > > > drivers/infiniband/ulp/Makefile | 1 + > > > drivers/infiniband/ulp/rtrs/Kconfig | 27 +++++++++++++++++++++++++++ > > > drivers/infiniband/ulp/rtrs/Makefile | 15 +++++++++++++++ > > > 4 files changed, 44 insertions(+) > > > create mode 100644 drivers/infiniband/ulp/rtrs/Kconfig > > > create mode 100644 drivers/infiniband/ulp/rtrs/Makefile > > > > How is this using ib_devices without having a struct ib_client ? > Hi Jason, > > After we resolved address using rdma_resolve_add() we access the > ib_device from rdma_cm_id. The ib_device has been registered on > rdma_cm module load in cma_init(). The handle device removal through > RDMA_CM_EVENT_DEVICE_REMOVAL. Hmm.. I actually don't know if this flow works OK in rdma cm or not.. Actually I expect if I look at rdma cm, I'll find it is broken.. However, it does sound like a reasonable approach, so nothing to do here. Jason