[PATCH liburing 0/2] spec: RPM spec file changes for liburing-0.5

[PATCH liburing 0/2] spec: RPM spec file changes for liburing-0.5

[Stefan Hajnoczi]

These patches fix issues with the liburing-0.5 RPM spec file.  I encountered
them when packaging it for Fedora.

Stefan Hajnoczi (2):
  spec: use "or" instead of "/" in License line
  spec: add ./configure --libdevdir= for development package files

 liburing.spec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.24.1

[PATCH liburing 1/2] spec: use "or" instead of "/" in License line

[Stefan Hajnoczi]

rpmlint on Fedora 31 complains about "LGPLv2+ / MIT" because "/" is not
allowed.  Use "or" instead.

Fixes: 783831a0548d3c702bd18746b5f425106f10e090
       ("Include MIT notice in rpm spec and debian package file")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 liburing.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/liburing.spec b/liburing.spec
index b09c6e1..987946d 100644
--- a/liburing.spec
+++ b/liburing.spec
@@ -2,7 +2,7 @@ Name: liburing
 Version: 0.6
 Release: 1%{?dist}
 Summary: Linux-native io_uring I/O access library
-License: LGPLv2+ / MIT
+License: LGPLv2+ or MIT
 Source0: https://brick.kernel.dk/snaps/%{name}-%{version}.tar.gz
 Source1: https://brick.kernel.dk/snaps/%{name}-%{version}.tar.gz.asc
 URL: https://git.kernel.dk/cgit/liburing/
-- 
2.24.1

[PATCH liburing 2/2] spec: add ./configure --libdevdir= for development package files

[Stefan Hajnoczi]

The development package files (--libdevdir=) have been separated from
the library runtime package files (--libdir=).  Make sure to set
--libdevdir= so x86_64 Fedora RPMs are built for /usr/lib64 instead of
/usr/lib.

Cc: Stefan Metzmacher <metze@samba.org>
Fixes: 3e63af4f252e1dfc2cb736863d8db4a3821f48e4
       ("Fix liburing.so symlink source if libdir != libdevdir")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 liburing.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/liburing.spec b/liburing.spec
index 987946d..1665c7c 100644
--- a/liburing.spec
+++ b/liburing.spec
@@ -26,7 +26,7 @@ for the Linux-native io_uring.
 
 %build
 %set_build_flags
-./configure --prefix=%{_prefix} --libdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
+./configure --prefix=%{_prefix} --libdir=/%{_libdir} --libdevdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
 
 %make_build
 
-- 
2.24.1

Re: [PATCH liburing 0/2] spec: RPM spec file changes for liburing-0.5

[Jens Axboe]

On 3/19/20 7:26 AM, Stefan Hajnoczi wrote:
> These patches fix issues with the liburing-0.5 RPM spec file.  I encountered
> them when packaging it for Fedora.
> 
> Stefan Hajnoczi (2):
>   spec: use "or" instead of "/" in License line
>   spec: add ./configure --libdevdir= for development package files
> 
>  liburing.spec | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

BTW, we have io-uring@vger.kernel.org, that's probably a better list to use
going forward.

-- 
Jens Axboe