From: Yufen Yu <yuyufen@huawei.com>
To: <axboe@kernel.dk>, <linux-block@vger.kernel.org>
Cc: <tj@kernel.org>, <jack@suse.cz>, <bvanassche@acm.org>,
<tytso@mit.edu>, <gregkh@linuxfoundation.org>
Subject: [PATCH v3 0/4] bdi: fix use-after-free for bdi device
Date: Mon, 23 Mar 2020 21:22:50 +0800 [thread overview]
Message-ID: <20200323132254.47157-1-yuyufen@huawei.com> (raw)
Hi, all
We have reported a use-after-free crash for bdi device in __blkg_prfill_rwstat().
The bug is caused by printing device kobj->name while the device and kobj->name
has been freed by bdi_unregister().
In fact, commit 68f23b8906 "memcg: fix a crash in wb_workfn when a device disappears"
has tried to address the issue, but the code is till somewhat racy after that commit.
In this patchset, we try to protect bdi->dev with spinlock, and copy device name
into buffer, avoiding use-after-free.
V2:
https://www.spinics.net/lists/linux-fsdevel/msg163206.html
Rry to protect device lifetime with RCU.
V1:
https://www.spinics.net/lists/linux-block/msg49693.html
Add a new spinlock and copy kobj->name into caller buffer.
Or using synchronize_rcu() to wait until reader complete.
Yufen Yu (4):
bdi: use bdi_dev_name() to get device name
bdi: add new bdi_get_dev_name()
bdi: replace bdi_dev_name() with bdi_get_dev_name()
bdi: protect bdi->dev with spinlock
block/bfq-iosched.c | 6 +++--
block/blk-cgroup-rwstat.c | 6 +++--
block/blk-cgroup.c | 19 +++++-----------
block/blk-iocost.c | 14 +++++++-----
block/blk-iolatency.c | 5 +++--
block/blk-throttle.c | 6 +++--
fs/ceph/debugfs.c | 2 +-
fs/fs-writeback.c | 4 +++-
include/linux/backing-dev-defs.h | 1 +
include/linux/backing-dev.h | 23 +++++++++++++++++++
include/linux/blk-cgroup.h | 1 -
include/trace/events/wbt.h | 8 +++----
include/trace/events/writeback.h | 38 ++++++++++++++------------------
mm/backing-dev.c | 9 ++++++--
14 files changed, 85 insertions(+), 57 deletions(-)
--
2.17.2
next reply other threads:[~2020-03-23 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 13:22 Yufen Yu [this message]
2020-03-23 13:22 ` [PATCH v3 1/4] bdi: use bdi_dev_name() to get device name Yufen Yu
2020-03-23 16:52 ` Christoph Hellwig
2020-03-23 13:22 ` [PATCH v3 2/4] bdi: add new bdi_get_dev_name() Yufen Yu
2020-03-23 13:22 ` [PATCH v3 3/4] bdi: replace bdi_dev_name() with bdi_get_dev_name() Yufen Yu
2020-03-23 16:54 ` Christoph Hellwig
2020-03-23 13:22 ` [PATCH v3 4/4] bdi: protect bdi->dev with spinlock Yufen Yu
2020-03-23 14:04 ` Greg KH
2020-03-23 14:10 ` Yufen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323132254.47157-1-yuyufen@huawei.com \
--to=yuyufen@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).