From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0E1C43331 for ; Thu, 26 Mar 2020 15:55:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF10220775 for ; Thu, 26 Mar 2020 15:55:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qPCV1Rns" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727699AbgCZPz6 (ORCPT ); Thu, 26 Mar 2020 11:55:58 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:55358 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbgCZPz6 (ORCPT ); Thu, 26 Mar 2020 11:55:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6p7M0oF06E9R88/xU23XER6eK4MkYLCH3j3MxDEX7fw=; b=qPCV1RnsoX1EfevxTvJ7K14S0D bPw4mn5ohQol+5sF6Sk9KKiStYtLusdBF9m/78N5T6dAZQgZO15UF338ljaTBiDb2PTbvT05ZhFq+ smn5z89yq4vQDdpFivGrQZQAuIbPI7zYLGc2qKIL1s0Oxapu+E3SQUaGUY7ni5/8ZTxzkP7DLtxrK IHw3XwZV5eL2ufFAjHq/gdfaZGECZy1dlwWhxPh8RJmrixEsSiNG3GH1N+Ii5CJzDb8NlQuFZK5HG Vumu4jlqDOUA+a+4AhQXQNqUontS51b5mDOwfohl+0BmNqas8VOwdZDtV2b+IrCPVmXnqSqfCPnJN ThfhlSQA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHUrN-0001x6-KM; Thu, 26 Mar 2020 15:55:57 +0000 Date: Thu, 26 Mar 2020 08:55:57 -0700 From: Christoph Hellwig To: Evan Green Cc: Christoph Hellwig , Andrzej Pietrasiewicz , linux-block , Jens Axboe , kernel@collabora.com Subject: Re: [PATCH RESEND 1/2] loop: Report EOPNOTSUPP properly Message-ID: <20200326155557.GA6043@infradead.org> References: <20200317151111.25749-2-andrzej.p@collabora.com> <20200317165106.29282-1-andrzej.p@collabora.com> <20200326145253.GA18623@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Mar 26, 2020 at 08:51:21AM -0700, Evan Green wrote: > On Thu, Mar 26, 2020 at 7:53 AM Christoph Hellwig wrote: > > > > On Tue, Mar 17, 2020 at 05:51:06PM +0100, Andrzej Pietrasiewicz wrote: > > > From: Evan Green > > > > > > Properly plumb out EOPNOTSUPP from loop driver operations, which may > > > get returned when for instance a discard operation is attempted but not > > > supported by the underlying block device. Before this change, everything > > > was reported in the log as an I/O error, which is scary and not > > > helpful in debugging. > > > > This really should be using errno_to_blk_status. > > I had that here in v7: > https://lore.kernel.org/lkml/20191114235008.185111-1-evgreen@chromium.org/ Well, it wasn't in the version you sent the ping for..